Fix test performance of Drupal\Tests\user\FunctionalJavascript\UserPasswordResetTest

>I think olivero_test could be renamed. But it adds an article content type with comment field. Which is being checked in this test.

Hi, @smustgrave, are you sure? I checked the file and did not see node/content type/comment involved in UserPasswordResetTest. olivero_test is for testing the olivero theme, which is irrelevant here.

Yea gotta figure out what about that module makes it work. Without it the test seems to have an issue with the picture upload.

Ok, will try. BTW, deprecated REQUEST_TIME usage in UserPasswordResetTest could be fixed

Saw that didn’t know if it could get kicked back as out of scope

The title starts with Fix test performance, I think it's ok to do #12

>Yea gotta figure out what about that module makes it work. Without it the test seems to have an issue with the picture upload.

It's the user under testing without the access content permission

Sorry, the interdiff in #14 is wrong, as the patch in #14 is a simple patch, I will not re-upload a correct interdiff.

Worthy re-uploading a correct interdiff-5-14.txt for review

Update core/phpstan-baseline.neon

Interesting wonder why that permission solved it?

Seems to have CI failures

#17 Removed the wrong entry from core/phpstan-baseline.neon

          return AccessResult::allowedIfHasPermission($account, 'access content');

Re #18 Checked core/modules/file/src/FileAccessControlHandler.php, see the source code here

Learn something new everyday!

Thanks for figuring that out!

$ grep -nR "\$profile\ =\ 'standard'" .
./core/tests/Drupal/FunctionalTests/Installer/StandardInstallerTest.php:15:  protected $profile = 'standard';
./core/profiles/standard/tests/src/FunctionalJavascript/StandardJavascriptTest.php:18:  protected $profile = 'standard';
./core/profiles/standard/tests/src/Functional/StandardTest.php:30:  protected $profile = 'standard';
./core/modules/config_translation/tests/src/Functional/ConfigTranslationInstallTest.php:22:  protected $profile = 'standard';
./core/modules/migrate_drupal_ui/tests/src/Functional/MigrateUpgradeTestBase.php:23:  protected $profile = 'standard';
./core/modules/config/tests/src/Functional/ConfigImportAllTest.php:34:  protected $profile = 'standard';
./core/modules/system/tests/src/Functional/Common/NoJavaScriptAnonymousTest.php:26:  protected $profile = 'standard';
./core/modules/system/tests/src/Functional/Theme/EntityFilteringThemeTest.php:38:  protected $profile = 'standard';
./core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php:47:  protected $profile = 'standard';
./core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php:24:  protected $profile = 'standard';
./core/modules/node/tests/src/Functional/NodeTranslationUITest.php:62:  protected $profile = 'standard';
./core/modules/content_translation/tests/src/Functional/ContentTranslationStandardFieldsTest.php:31:  protected $profile = 'standard';
./core/modules/content_translation/tests/src/Functional/ContentTranslationMetadataFieldsTest.php:38:  protected $profile = 'standard';
./core/modules/help/tests/src/Functional/HelpTest.php:36:  protected $profile = 'standard';
./core/modules/media/tests/src/FunctionalJavascript/MediaStandardProfileTest.php:25:  protected $profile = 'standard';

There are more to do.

There's a meta attached for tracking those. Some are required.

Oh, missed the linked parent issue, thanks!

Backported to 10.0.x as a test-only fix. Doesn't cherry-pick cleanly to 9.5.x due to the PHPStan baseline, not sure it is worth the effort, so I left that branch alone.

Committed and pushed 1ac46a2af3 to 10.1.x and 2fdab0bde3 to 10.0.x. Thanks!

This broke HEAD in 10.0.x:

1) Drupal\Tests\user\FunctionalJavascript\UserPasswordResetTest::testUserPasswordResetWithAdditionalAjaxForm
Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by test_user_config have unmet dependencies: core.entity_form_display.user.user.default (image.style.thumbnail, image), field.field.user.user.user_picture (image, field), field.storage.user.user_picture (file, image, field)

Rolled back from there, this isn't critical so can go into 10.1.x only.

Automatically closed - issue fixed for 2 weeks with no activity.