The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- πΊπΈUnited States smustgrave
Actually wondering if this should be changed. It needs a number of modules, content type, vocabulary, etc so essentially it's a standard install no?
- π³πΏNew Zealand quietone
It is still better to test without relying on the standard profile. That profile installs 32 modules whereas this test is now using 9 modules, that is a significant reduction.
Also, it helps in the module list is sorted and needs to convert to an MR.
- Assigned to smustgrave
- Merge request !5565Issue #2254199 by smustgrave, sun, vacho: Fix test performance of... β (Open) created by smustgrave
- Status changed to Needs review
over 1 year ago 12:55am 28 November 2023 - Status changed to Needs work
over 1 year ago 9:24am 30 November 2023 - Status changed to Needs review
over 1 year ago 11:34pm 30 November 2023 - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 11:11pm 4 December 2023 - π΅πͺPeru marvil07
@smustgrave, changes look quite lean π.
After @quietone's suggestion on the last review round, I think the set of used modules in the test is the minimal set.
Locally, even if different and likely slower than gitlab runners, I see an improvement jump in test time for that test from 01:04.356 to 00:55.312.
Marking as RTBC.
- Status changed to Fixed
over 1 year ago 10:33am 5 December 2023 - π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.