Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

 dependencies:
-  - recurly
+  - drupal:recurly

The Recurly → module is not a Drupal core module.

-    if ($recurly_account = recurly_account_load(['entity_type' => $entity_type_id, 'entity_id' => $entity->id()])) {
+    if ($recurly_account = recurly_account_load(
+        ['entity_type' => $entity_type_id, 'entity_id' => $entity->id()]
+    )) {

-        if ($url = recurly_url('select_plan', ['entity_type' => $entity_type, 'entity' => $entity])) {
+        if ($url = recurly_url('select_plan',
+            ['entity_type' => $entity_type, 'entity' => $entity])) {
           return $this->redirect($url->getRouteName(), $url->getRouteParameters());

Control structure conditions may exceed 80 characters, if they are simple to read and understand → .

-/**
- * RecurlyFormatManager.
+ * Factory for format manager of Recurly RecurlyFormatManager class.

How can a class be a factory for itself?

-    if ($recurly_account = recurly_account_load(['entity_type' => $entity_type_id, 'entity_id' => $entity->id()])) {
+    if ($recurly_account = recurly_account_load([
+      'entity_type' => $entity_type_id,
+      'entity_id' => $entity->id(),
+    ]
+    )) {
       if ($url = recurly_hosted_account_manage_url($recurly_account, TRUE)) {

Control structure conditions may exceed 80 characters, if they are simple to read and understand → . That code is formatted following the PSR12 coding standards, not the Drupal coding standards.

 description: 'Provides a Form API Recurly.js field and integration with the Field and Entity systems.'
 dependencies:
-  - recurly
+  - drupal:recurly

The Recurly → module is not a Drupal core module.

+  /**
+   * The state store.
+   *
+   * @var Drupal\Core\State\State
+   */
+  protected $state;
+

    *   The Recurly format manager.
+   * @param \Drupal\Core\State\State $state
+   *   The object State.

The first description is better. Parameters are not described as being objects. That is something already said from the @param line.

   public function __construct(
     CountryManagerInterface $country_manager,
     ContainerAwareEventDispatcher $event_dispatcher,
     RecurlyClientFactory $client,
-    RecurlyFormatManager $format_manager
+    RecurlyFormatManager $format_manager,
+    State $state
   ) {
     $this->countryManager = $country_manager;
     $this->eventDispatcher = $event_dispatcher;
     $this->recurlyClient = $client;
     $this->formatManager = $format_manager;
+    $this->state = $state;
   }

Function/method declarations are written in a single line, as per Drupal coding standards.

eojthebrave → closed merge request !6

eojthebrave → closed merge request !20

Thank you to everyone who has helped work on this so far. It's a big undertaking. And will be nice to have it completed.

I created a new MR using the previously created MR in #20. It was quite a bit behind the 4.x branch and needed some updates. I made the new MR against the 5.x branch which targets Drupal 9 and 10. And it's now updated and passing the GitLab PHPCS checks.

I also created another MR against the 4.x branch. Which is for Drupal 8 and 9. With the same updates. And it's also passing the GitLab PHPCS checks.

I recommend reviewing the 3267917-5x-phpcs-cleanup branch. The other one is the same changes backported to the slightly older code in the 4.x branch.

My current plan is to get this merged in. And then create a 5.0.0 release so there's a Drupal 10 compatible stable release of the module.

Both the 4.x and 5.x branches are now passing the phpcs scans done by GitLab CI, and there's a different issue for dealing with the 7.x-2.x branch here https://www.drupal.org/project/recurly/issues/2872780 📌 Fix the issues reported by phpcs Needs work . And the 8.x-X branch isn't seeing active development anymore so not likely to ever get these changes.

I think we can close this issue now. Thank you to everyone that has contributed to getting the code cleaned up.

Automatically closed - issue fixed for 2 weeks with no activity.