as patch in #15 failed here is updated reroll of #9 against drupal 10.1.x
trying to solve failure in #15 here is updated patch with interdiff
- First commit to issue fork.
- @klonos opened merge request.
- 🇦🇺Australia klonos 90% Melbourne, Australia - 10% Larissa, Greece
Sorry for crossing wires here. Since there is so much interest to contribute by multiple members, I have created a fork/branch and applied the patch from #16 (thank you Nikhil_110), then fixed failures. This way, we can all add commits to that branch instead of having to upload multiple patch files here, and to keep re-rolling them. Lets please do that, shall we?
There was another instance in core/misc/vertical-tabs.js that was appending the span with the "active tab" indicator, so I've changed that to be adding a single space before the span.
I've also updated the issue summary, to fix a typo, and change the suggestion to consider using "aria-selected" (instead of the original proposal to use "aria-current").
- 🇦🇺Australia klonos 90% Melbourne, Australia - 10% Larissa, Greece
...I will leave this MR here to help us collaborate, but from reading through this thread it seems to me that we need a decision with re to whether it is preferred to keep using a hidden span, or to remove that and use
aria-selectedinstead? (or do both?). Until we know what works best for a11y, we cannot really move this forward. - First commit to issue fork.
- 🇳🇱Netherlands groendijk
Agree with the suggention of Klonos. Remove the hidden span and use
aria-selected. Following the MDN Web Docs https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/ta... they recommend to use that. Also best practice to usebuttonbut perhaps that is outside of this issue scope.