Passing null to parameter #1 ($num) of type int|float to abs() is deprecated

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

See starting in #26 a different approach was taken. But that lost test coverage. Could we add one back?

Thanks!

Here's a test-only should-fail patch

The last submitted patch, 35: 3255699-35-TEST-ONLY-FAIL.patch, failed testing. View results →

Removed "needs tests" tag as we now have a functional test

Minor but what solution are we going with? Proposed solution section has 4 possibilities. Think it will help the committers to know which to look for.

I can see the same deprecation when file e.g image without filesize is attached to a form, so ImageWIdget or FIleWidget table try to render image without filesize. We use S3FS to store files.

@lamp5 hopefully #37 works fine as a fix and you could provide a review?

When using S3FS do most files have a size and only occasionally the size is NULL for some reason? If so then #37 seems (to me) like a good solution - printing "Unknown" in the table for those rare cases where something went wrong when determining the file size.

Thanks @mfb for updating issue summary.

Ran tests locally to make sure they fail

Exception : Deprecated function: abs(): Passing null to parameter #1 ($num) of type int|float is deprecated
format_size()() (Line: 137)

Which is good.

Change matches issue summary think this is good.

Decided to backport to 10.1.x as a minor fix for an edge case.

Committed and pushed 5f3e8885b8 to 11.x and 9b55418bba to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.