Update migration warning 'There is translated content of these types'

That issue has gone nowhere in 2 years.

In the meantime, could the wording be tweaked at least to be less scary?

The code comment says:

        // Translations are not yet supported by the audit system. For now, we
        // only warn the user to be cautious when migrating translated content.
        // I18n support should be added in https://www.drupal.org/node/2905759.

That is far more reasonable -- "We don't audit translations, so we don't know if you have translated content, but if you do, you need to be careful" is much better than saying "It looks like you are migrating translated content from your old site" which in a lot of cases is downright untrue, and therefore confusing and scary.

Though I still also wonder whether there is something that can be fixed here.

The message is showing because \Drupal\migrate\Plugin\migrate\destination\EntityContentBase::isTranslationDestination() is finding this in its configuration:

array:3 [▼
  "plugin" => "entity_complete:node"
  "translations" => true
  "default_bundle" => "product_kit"
]

Why is translations TRUE?

I agree @joachim. Getting a false positive is bad UI, and like cookie warnings, quickly clicked by, teaching the user to ignore such warnings.

We risk a "Boy Who Cried Wolf"-situation, where warnings are ignored.

Checking if there actually is translated content in the first place, and don't show it if not is best. But your suggestion to rephrase it is great.

Until the other issue is completed, is there a way to override this warning via a custom module, to set "translations" => false, or some other way to automatically bypass the warning?

Scratched the other proposed solutions as this appears to just be updating the text.

Also updated title.

Thanks for fast review @smustgrave. Do you happen to know if it's hard to bypass the warning via a custom module?

Maybe a form_alter? Only thing that comes to mind.

I patched the migrate_drupal_ui/src/Form/IdConflictForm.php file itself, and check if Language module is installed. If not, it skips over the "There is translated content of these types" prompt screen. It may not be the correct solution, but for now it works well for me, in single language migrations.

There are a couple UI text standards issues with the proposed change set. Added suggestions on the MR.

Once those are addressed, we should also have an additional review from a Migrate subsystem maintainer, especially since @quietone previously stated she considered this wontfix.

Thanks for the review @xjm, great suggestions which I all accepted.

@quietone made Comment #3 with the original issue description: just the "Problem/Motivation" section, nothing under "Proposed resolution". I do not think that counts as a vote for "won't fix" updating the UI text.

I reviewed the code changes, including the updated link. (The old link redirects to the new one.) I agree that the change is an improvement.

I tested with and without the proposed changes, starting with fresh installations of the Standard and Umami profiles. I think it is important to look at the case where the is (translated) content that might be overwritten. I am adding screenshots and text to the issue summary, under "User interface changes".

@benjifisher, thanks for the thorough testing. This is an improvement that will help the person migrating a sight.

+1 from me too.

Nice work everyone. This looks good to me now as well, and the screenshots are definitely helpful.

I rebased the MR to get a fresh test run.

Tests passed. Yay.

Committed to 11.x. I did not backport this to 10.2.x as there are string changes and we're in the release candidate phase for it.

Automatically closed - issue fixed for 2 weeks with no activity.