Contrib.social

Users should be able to reply to a specific comment even when threading is disabled

Open on Drupal.org →
Created on 6 August 2021, almost 3 years ago
Updated 28 November 2023, 7 months ago

The "reply" link is not shown in the links list (under all comment) if the "Show comment replies in a threaded list" flag is not set in the "comment" field settings for node.

I think it is incorrect. If the comments are in a flat mode (not in a threaded list), then a comment (for example) may simple have note: "A reply to comment #23 (and link to the comment)".

<!--break-->

Core comment module > CommentLazyBuilders.php > line 185

if ($entity->access('create')
  && $field_definition->getSetting('default_mode') === CommentManagerInterface::COMMENT_MODE_THREADED) {
  $links['comment-reply'] = [
    'title' => t('Reply'),
    'url' => ...
  ];
}

This code excludes "Reply" link for flat comments. Previously, the logic was different and I think it needs to be returned.

✨ Feature request
Status

Closed: won't fix

Version

11.0 🔥

Component
Comment  →

Last updated about 21 hours ago

Created by

🇷🇺Russia ru.bsv Omsk

Live updates comments and jobs are added and updated live.
  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 7 months ago →
    🇳🇱Netherlands timohuisman Leiden, Netherlands

    We need this option as well. This patch provides a additional setting at the comment item form so you can enable the reply-link without enabling the threaded messages.

    I think that the tests needs to be updated, but I'm not yet familiar with that proces. And the new setting is overruled by the default_mode setting, that should maybe be indicated in the ui?

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MariaDB 10.3.22
    last update 7 months ago
    30,589 pass, 7 fail
  • Comment 7 months ago →
    🇺🇸United States smustgrave

    #3 one of the submaintainer says this was done intentionally. He suggests that the service could be swapped out with custom code. May be worth a contrib module but for core not sure.

  • Status changed to Closed: won't fix 7 months ago
  • Comment 7 months ago →
    🇫🇷France andypost

    I see no reason as maintainer as well

    Moreover for this kind of settings better to use comment type as config entity extendable via third_party API
    But for more precise control custom code could use setting at formatter level to store extra setting in display

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024