Putting "." in a plugin ID will cause problems if you attempt to store configured plugins via the Configuration API

Created on 25 May 2021, about 3 years ago

Updated 4 February 2023, over 1 year ago

Problem/Motivation

If you store a plugin in config (e.g. via LazyPluginCollection, see EntityWithPluginCollectionInterface), if plugin IDs have a . in them there will be validation errors preventing the config from saving.

Steps to reproduce

@todo

Proposed resolution

DefaultPluginManager can warn when plugin IDs have . in them.

Remaining tasks

Write steps to reproduce
Decide on wording
Decide on error type (E_USER_WARNING vs E_USER_DEPRECATED)?
Write tests
Write CR

User interface changes

N/A

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Plugin →

Last updated about 18 hours ago

Maintained by
🇺🇸United States @EclipseGc
🇺🇸United States @effulgentsia
🇺🇸United States @tim.plunkett

Created by

🇺🇸United States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.

Configuration system

Plugin system

DX (Developer Experience)
Enhances developer experience.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs steps to reproduce

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇸United States smustgrave
Can you update the MR for 10.1 please

Also there is a @todo in the IS you can fill that in.

Thanks!
Comment over 1 year ago →
🇺🇸United States tim.plunkett Philadelphia
Updated branch.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024