Remove block dependency from block_content

Now that we have moved block_content we may be able to remove the dependency.

So tested removing block as a dependency and can already see failures happening.

Seems like it would be more effort to remove block. There's also a preDelete call on the entity

    parent::preDelete($storage, $entities);

    /** @var \Drupal\block_content\BlockContentInterface $block */
    foreach ($entities as $block) {
      foreach ($block->getInstances() as $instance) {
        $instance->delete();
      }
    }

Which seems dependent on block.

Going to say this works as designed if anyone disagrees please reopen explaining why

Thanks!

I think it should still be possible to remove the dependency on block.module, it just may need a bit of refactoring. The \Drupal\block_content\BlockContentInterface::getInstances method (used in preDelete) provides special handling for block.module but completely ignores layout builder. It probably makes more sense to have a separate service for this integration, and the block instance deletion should probably be implemented in a hook. In other words, the BlockContent entity should have no awareness of Block entities.

Lets see if anyone picks it up.

We haven't addressed #11 and #12 yet.

Which leads me to believe we're missing test coverage for that when block.module is disabled.

\Drupal\block_content\Entity\BlockContent::getInstances should hard fail when the block entity-type doesn't exist.

There's also a reference to block.admin_library in block_content.links.action.yml - it would be good to confirm that doesn't cause any side-effects.

block_content_add_action:
  route_name: block_content.add_page
  title: 'Add content block'
  appears_on:
    - block.admin_library ## here
    - entity.block_content.collection
  class: \Drupal\block_content\Plugin\Menu\LocalAction\BlockContentAddLocalAction