- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
+1 for RTBC
I applied the patch from Merge Request 15 right before comment #23. To do this, I visited the merge request in GitLab at https://git.drupalcode.org/project/entity_clone/-/merge_requests/15, and then added
.diff
to the URL to create a downloadable patch.I then saved the patch in my repository and applied it using composer:
"patches": { "drupal/entity_clone": { "Add a way to exclude certain entity types from cloning": "./patches/entity_clone-3205355-mr15-comment23.patch" } },
After applying the patch to the dev branch of the module, I am presented with a nice configuration page at
/admin/config/system/entity-clone/cloneable-entities
After this I confirmed that the clone option shows up on the selected entities, and not on the unselected.
Thanks for all the work on this!
- 🇬🇧United Kingdom ieguskiza
I left a comment in the PR, notably the implementation of hook_modules_installed seems problematic to me, since every time a module is enabled that adds a new entity type any previously stored config is overriden.
- Status changed to Needs work
almost 2 years ago 5:09pm 8 February 2023 - Status changed to Needs review
almost 2 years ago 1:48pm 9 February 2023 - 🇧🇪Belgium joevagyok
Thank you @ieguskiza, nice catch. I pushed a fix that replaces the hook with an event subscriber that will ensure new entity types are clonable by default.
- Status changed to RTBC
almost 2 years ago 9:54am 13 February 2023 - 🇬🇧United Kingdom ieguskiza
Much better solution with the event subscriber, now only new entity types are updated while keeping the configuration intact.
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Updates Version to 2.x-dev
- Assigned to rajeshreeputra
- 🇮🇳India rajeshreeputra Pune
Reviewed MR, changes looks really cool. Will merge this weekend followed by release.
-
Rajeshreeputra →
committed b156daed on 2.x authored by
joevagyok →
Issue #3205355 by joevagyok, Rajeshreeputra, stijndmd, aspilicious,...
-
Rajeshreeputra →
committed b156daed on 2.x authored by
joevagyok →
- Status changed to Fixed
over 1 year ago 6:26am 25 March 2023 - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 6:16pm 21 April 2023 - heddn Nicaragua
Can a new tag be released so I can fix issues w/ Group module?
See 🐛 Group error createAccess() must implement interface Drupal\group\Entity\GroupInterface, null given Needs review and 🐛 Entity clone invokes any entity type's createAccess() without knowing about required context values Active for examples.