Import should overwrite files

+1 RTBC

There's new patch after RTBC and MR

Can we make it configurable?

sure, will test this again and post the results

AFAICT the proposed changes here are identical to the changes proposed as of #5, at which point there was test coverage and the behaviour was more consistent. I think this is good to merge.

This appears to work as it says on the tin, which is good - it eliminates a "round trip" issue where executing drush dcim example will generate a new filename for any files which already exist in the destination location, after which a drush dcem example will update the default content exports to append a _0 suffix ... then _1, then ...

👍

To early to require 10.3.

Hi,

MR rebased to have a patch appliable on the 2.0.0-alpha3.

grimreaper → changed the visibility of the branch 3200212-rebased-2.0.0-alpha3 to hidden.

grimreaper → changed the visibility of the branch 3200212-rebased-2.0.0-alpha3 to active.

Hum, strange, MR is rebased, I also tried another one with only one commit. But patch is not applicable

Idea, I think it is because of changes in .info.yml

Now applicable.

I don't think this sufficiently tests that additional files were not created:

    // Assert the files, since a file already existed at that location, one has
    // been overwritten.
    $files = \Drupal::entityTypeManager()->getStorage('file')->loadByProperties(['filename' => 'test-file.txt']);
    $this->assertCount(1, $files);

The file is created during the test with file_put_contents(), so an entity for it won't exist in the database. To confirm this, I removed all but the test from the patch, and it didn't fail.