- ๐ฉ๐ฐDenmark ressa Copenhagen
I just installed the Honeypot module, and by chance (I forget where) I saw that it offered a Tour. It made me remember that the Tour link is hard to find, and it took me some time to scan the entire screen, when I finally found the "Tour" link, hidden in the upper right corner. It's so sad that it sits hidden up there ...
- Status changed to Needs review
over 1 year ago 3:20am 17 March 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have attached patch for 10.1.x. please review
Patch #18, no longer applies
git apply -v 161.patch Checking patch core/modules/tour/tour.module... Checking patch core/themes/claro/css/theme/toolbar.icons.theme.css... Checking patch core/themes/claro/css/theme/toolbar.icons.theme.pcss.css... Checking patch core/modules/contextual/css/contextual.toolbar.css... error: while searching for: } .toolbar .toolbar-bar .contextual-toolbar-tab .toolbar-item { margin: 0; } .toolbar .toolbar-bar .contextual-toolbar-tab .toolbar-item.is-active { background-image: -webkit-linear-gradient(rgb(78, 159, 234) 0%, rgb(69, 132, 221) 100%); error: patch failed: core/modules/contextual/css/contextual.toolbar.css:12 error: core/modules/contextual/css/contextual.toolbar.css: patch does not apply
- ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks @Gauravvvv, I updated the existing merge request target branch from 9.2 to 10.1, and rebased it by clicking "Rebase without pipeline":
To rebase a merge requestโs branch without triggering a CI/CD pipeline, select Rebase without pipeline from the merge request reports section. This option is available when fast-forward merge is not possible but a conflict-free rebase is possible.
So the current MR !161 should now work with Drupal 10.1.
- Status changed to Needs work
over 1 year ago 1:22pm 17 March 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
Perhaps we can now look at the review by @himanshu_sindhwani in #17 ๐ Make Tour link more visible Needs work , about not removing the transparency?
- ๐บ๐ธUnited States smustgrave
Just FYI ๐ฑ [Policy] Remove tour module from core Fixed
-
smustgrave โ
committed 7d0e6199 on 2.0.x
Issue #3186076 by Pooja Ganjage, ressa, Gauravvvv, ranjith_kumar_k_u,...
-
smustgrave โ
committed 7d0e6199 on 2.0.x
- Status changed to Fixed
7 months ago 5:25pm 5 May 2024 - ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks for taking over the maintenance of the Tour module @smustgrave, I really appreciate it.
- ๐บ๐ธUnited States smustgrave
No problem! Really hoping to bring some new life to the module. Probably should start a 2.0.0 meta soon
- ๐ฉ๐ฐDenmark ressa Copenhagen
Cool, I am looking forward to version 2, and trying it out! Have a nice day.
Automatically closed - issue fixed for 2 weeks with no activity.