- Status changed to Needs work
almost 2 years ago 10:55am 16 January 2023 - Status changed to RTBC
almost 2 years ago 4:37pm 16 January 2023 - Status changed to Needs work
almost 2 years ago 1:06am 8 February 2023 - 🇳🇿New Zealand quietone
Close, just some doc comment tidy up.
Needs work for the comments on the MR.
- Assigned to philipnorton42
- @philipnorton42 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:49pm 8 February 2023 - 🇬🇧United Kingdom philipnorton42 Cheshire
Ok, I figured out how to do change the target to 10.1.x and created another MR, this means we have two for this request:
9.5.x - https://git.drupalcode.org/project/drupal/-/merge_requests/2801
10.1.x - https://git.drupalcode.org/project/drupal/-/merge_requests/3423I found these instructions that managed to perform the desired effect - https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →
I hope this is correct. Let me know if I've done anything wrong here. I'll pop this back to "needs review".
- Status changed to RTBC
almost 2 years ago 4:15pm 25 February 2023 - 🇺🇸United States smustgrave
I reviewed 3423 and from what I can see it's using the dataprovider correction, everything is typehinted and commented. I don't see any issue.
-
larowlan →
committed d14562be on 10.0.x
Issue #3185183 by philipnorton42, larowlan, bruno.bicudo, longwave, xjm...
-
larowlan →
committed d14562be on 10.0.x
-
larowlan →
committed 950e7ff9 on 10.1.x
Issue #3185183 by philipnorton42, larowlan, bruno.bicudo, longwave, xjm...
-
larowlan →
committed 950e7ff9 on 10.1.x
-
larowlan →
committed 7ac5f521 on 9.5.x
Issue #3185183 by philipnorton42, larowlan, bruno.bicudo, longwave, xjm...
-
larowlan →
committed 7ac5f521 on 9.5.x
- Status changed to Fixed
almost 2 years ago 8:45pm 26 February 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 10.1.x and backported to 10.0.x and 9.5.x to keep the branches consistent as there's no risk of disruption here.
Automatically closed - issue fixed for 2 weeks with no activity.
