Menu migration should happen before block migration

Open on Drupal.org →

Created on 19 September 2020, over 4 years ago

Updated 8 March 2024, about 1 year ago

Problem/Motivation

When you run a migration using Migrate Upgrade, which leverages core's Migrate Drupal system, it runs the block migration before the menu migration, resulting in warnings that blocks from the menu system cannot be found, e.g.:

[warning] The "system_menu_block:secondary-menu" was not found

Steps to reproduce

Use Migrate Upgrade to prepare a D7 migration to D8 or D9 where menu blocks were displayed in a region.
Run the migration.

Proposed resolution

List the d7_menu migration as an optional dependency on d7_block.

Remaining tasks

Confirm the problem.
Provide a patch with the fix.
Test coverage.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Release notes snippet

TBD

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated 3 days ago

Maintained by
🇺🇸United States @benjifisher
@heddn
🇺🇸United States @mikelutz
🇳🇿New Zealand @quietone

Created by

🇺🇸United States DamienMcKenna NH, USA

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Bug Smash Initiative

Incomplete comments

Sign in to follow issues

Merge Requests

!11430Menu migration should happen before block migration
Open
🇺🇸United States dcam
updated 28 days ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇳🇿New Zealand quietone
This was a bug smash triage issue today.

We still need some tests here.
Comment 9 months ago →
🇳🇿New Zealand quietone
First commit to issue fork.
Merge request !11430Menu migration should happen before block migration → (Open) created by dcam
Pipeline finished with Failed
28 days ago
Total: 594s
#444173
Pipeline finished with Success
28 days ago
Total: 594s
#444178
Comment 28 days ago →
🇺🇸United States dcam
I don't think the test changes are any good. Neither undoing the fix nor removing d7_menu from the test's list of migrations will make the test fail. So I'm leaving the Needs Tests tag in place. But I'm marking this as Needs Review in hope that a subsystem maintainer will advise on what might be wrong or an alternate test strategy.
Comment 28 days ago →
🇫🇷France andypost
btw menus probably should be required migration as core has fixed default list independently from menu module since 8.x #2085243: Rename Menu module into Menu UI module →

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024