- πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
Tested following the steps in the IS using this chrome plugin https://chrome.google.com/webstore/detail/html5-form-validation-rem/dcpa...
Verified the issue and that the patch solves it.
Reading the comments see the last point #22 was addressed.
Good work.
- Status changed to Needs work
almost 2 years ago 2:17am 10 February 2023 - π³πΏNew Zealand quietone
This is testing a UI issue on an unsupported version of Drupal. Let's get this testing on a supported version of Drupal and check that is applies to 9.5, 10.0 and 10.1
This is changing the UI so adding tag. And let's get a ux review of the new text. And that will need screenshots available from the IS.
- last update
over 1 year ago 30,338 pass - Status changed to Needs review
over 1 year ago 8:40pm 7 June 2023 - π§π·Brazil igorbarato
I tested the patch on Drupal 9.5, 10.0, and 10.1 and it's working correctly. Adding screenshots of each version.
Drupal 9.5.x
Drupal 10.0.x
Drupal 10.1.x
- last update
over 1 year ago 28,523 pass - last update
over 1 year ago 29,418 pass - π³π±Netherlands yoroy
Thank you for the screenshots, they help with reviewing UI :)
Could the error message list the fields in order of their appearance on the form, so 'name' first, then 'paste...' if both have errors?
(Unrelated to the actual bug being worked on here, but anyone else find that "Paste your configuration here" label reading weirdly in context of the error message?)
- Status changed to RTBC
over 1 year ago 2:56pm 8 June 2023 - πΊπΈUnited States smustgrave
Thanks @yoroy
Moving back to RTBC has no code change has happened since #28
- last update
over 1 year ago 28,654 pass, 3 fail - Status changed to Needs review
over 1 year ago 3:32pm 8 June 2023 - π³π±Netherlands yoroy
I did have a question :)
Could the error message list the fields in order of their appearance on the form, so 'name' first, then 'paste...' if both have errors?
- Status changed to Needs work
over 1 year ago 5:44pm 8 June 2023 - πΊπΈUnited States smustgrave
That's a good catch. Also agree the errors should appear in the order of the form. Especially since there's no indicator which error goes to which form element.