The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇿New Zealand quietone
Tagging for coding standards and moving to the 'other' component where such issues live.
- Status changed to Needs review
over 1 year ago 4:40pm 2 June 2023 - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 4:49pm 2 June 2023 - 🇺🇸United States smustgrave
Issue summary is incomplete.
And this feels like counter active of only using t() in tests when testing translation.
- 🇮🇳India atul4drupal
Added patch for 11.x
Interdiff is not generated as the patch at #49 is not applying to have the interdiff generated (interdiff: Error applying patch1 to reconstructed file)IS to be updated...
- last update
about 1 year ago 30,392 pass - Status changed to Needs review
5 months ago 4:54am 30 July 2024 - 🇳🇿New Zealand quietone
The reason for this change is not in any of the comments and the documentation https://www.drupal.org/docs/develop/automated-testing/phpunit-in-drupal/phpunit-browser-test-tutorial#t clearly states not to do this. Thanks to @AJV009 for pointing that out.
What is the reason for doing this? How does it help developers?
- Status changed to Needs work
5 months ago 5:05am 30 July 2024 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)