- Assigned to nitin_lama
- last update
over 1 year ago PHPLint Failed - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - Status changed to Needs review
over 1 year ago 6:05am 2 January 2024 - Issue was unassigned.
- 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3151659-coding-standard-fixes to hidden.
- 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3151659-coding-standard-fixes to active.
- last update
about 1 year ago PHPLint Failed - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - Status changed to Needs work
about 1 year ago 5:02am 7 January 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
See remaining issues on failed pipelines: https://git.drupalcode.org/issue/scanner-3151659/-/pipelines/72900
- 🇺🇸United States DamienMcKenna NH, USA
The latest MR makes some changes I don't like:
* Hook arguments are changed.
* Array arguments are defined with a default of NULL, rather than an empty array.
* Some array definitions are changed to short arrays - we want to retain compatibility with PHP 5, so let's not do that.
* Inconsistent whitespace change.
* Some string translations have been removed.
* A code changes was made to scanner_execute() that removes a part of the query.
* Some syntax was changed to be shorter for PHP 7, this isn't something we can do.While I appreciate the work done, this can't be used as is.
- last update
12 months ago 12 pass - Status changed to Needs review
12 months ago 2:58pm 12 April 2024 -
DamienMcKenna →
committed bd5907fb on 7.x-1.x
Issue #3151659 by anoopsingh92, DamienMcKenna, VladimirAus, erikaagp,...
-
DamienMcKenna →
committed bd5907fb on 7.x-1.x
- Status changed to Fixed
12 months ago 3:15pm 12 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.