Required summary element hidden when other text-with-summary fields do not require summary

#30 faild to apply, because of #3181778: [w/c September 17th] Replace t() with $this->t() in all plugins →

interdiff-30-33.txt in #33 is empty. The following is supposed to be its content.

$ diff 3145850-30.patch 3145850-33.patch
2c2
< index 1dcb00b96b..1986fa120f 100644
---
> index 60b51650c8..3b1f541d7d 100644
6c6
<        '#title' => t('Summary'),
---
>        '#title' => $this->t('Summary'),

• #36 tested it manually,
• the test-only patch in #25 is still valid,
• #28 was addressed.

Thanks!

Hi I have created an MR . Please Merge. thanks

@kunal_sahu thanks for the interest but the patch #33 was already reviewed. So the MR is just reuploading the work that was already done. So removing credit for that unless there was something you were fixing.

Thanks

Updated attributions

+++ b/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php
@@ -94,10 +94,50 @@ public function testTextSummaryBehavior() {
+    $this->assertEquals(TRUE, $summary_field->isVisible(), 'Required summary is always shown.');

No need for the message here, as @quietone pointed out above in #28.

On second thoughts, I can fix that on commit.

Updating credits

Fixed on commit

diff --git a/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php b/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php
index 75f6768dea9..0867f962c95 100644
--- a/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php
+++ b/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php
@@ -137,7 +137,7 @@ public function testTextSummaryRequiredBehavior() {
     $page = $this->getSession()->getPage();
     $summary_field = $page->findField('edit-' . $field_name . '-0-summary');
 
-    $this->assertEquals(TRUE, $summary_field->isVisible(), 'Required summary is always shown.');
+    $this->assertEquals(TRUE, $summary_field->isVisible());
   }
 
 }

Committed to 10.1.x and backported to 10.0.x and 9.5.x

Manually tested with a multi-cardinality field as there's some JS regarding that, but it need not run if the summary is optional - so all good.

Automatically closed - issue fixed for 2 weeks with no activity.