Contrib.social

Change MenuLinkContent label to "Menu link text" instead of "Menu link title"

Open on Drupal.org →
Created on 3 May 2020, almost 5 years ago
Updated 5 February 2023, about 2 years ago

The current field-label for the link-text is Menu link title. Why exactly this phrase?

I would change two things:

  • "Menu" is already in the page's Title. No other field-label on this page has a "Menu-" prefix. Why does this field?
  • Why "title" and not "text"? In the URL-Field's help-text it is referred to as "link text" and i think something like link-text and link-url are kind of an "industry-standard"... at least for a text-link.

Mockup:

I am not native english speaking, but also the Label Link for the URL or path seems a bit un-precise to me: I thought "Link" refers to the whole thing, something that consists of a clickable object, a url/path it points to and maybe more.
If i am correct on that, this label should rather be "URL/Path" or so. In CKEditor it's called URL. In D7 it was Path, so i guess this was somewhere discussed already, when it was changed to Link in D8?

PS:
Mockup has also reordered fields, which is suggested in Issue 🐛 Changed field-order on add-menu-link admin page Closed: works as designed

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Menu UI  →

Last updated 2 days ago

No maintainer
Created by

🇨🇭Switzerland sirtet Switzerland

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇮🇳India Shubham Sharma 77

    Attached rerolled against branch 10.1.x,
    kindly review the patch.
    For ref sharing screenshots...

  • Comment about 2 years ago →
    🇮🇳India heni_deepak Jaipur, Rajasthan, India

    @shubham-sharma-77 looks good to me

  • Assigned to Sonal Gyanani
  • Comment about 2 years ago →
    🇮🇳India Sonal Gyanani
  • Issue was unassigned.
  • Status changed to RTBC about 2 years ago
  • Comment about 2 years ago →
    🇮🇳India Sonal Gyanani

    Tested patch #59 on drupal 10.1.x-dev version. Patch applied cleanly and looks good to me.

    Results:
    'Menu link title' label replaced with 'Menu link text'
    Refer to the screenshots.

    So moving it to RTBC.
    Thanks

  • Status changed to Needs work about 2 years ago
  • Comment about 2 years ago →
    🇳🇿New Zealand quietone

    @Sonal Gyanani, a change typically requires more work than testing to mark it RTBC. Have a look at RTBC → . That section has a link to the Contributor Task for reviewing an issue. The Contributor Guide is a good place to learn the steps to follow when working on an issue.

    This issue is tagged for a Usability review and an Issue Summary update. Those tasks still need to be done. I am setting this back to needs work.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024