Extend unit test coverage for LanguageNegotiationContentEntity

That was my suggestion, yes. Postpone this issue here, till the other one lands and then proceed with this one.
By that time, this issue will probably be better titled "Refactor LanguageNegotiationContentEntityTest to use a plugin factory trait".

Picking this up again; since 🐛 Fix LanguageNegotiationContentEntity::getLangcode() errors thrown Fixed has been fixed, the PR will need a few changes.

Tests were added in 🐛 Fix LanguageNegotiationContentEntity::getLangcode() errors thrown Fixed ; the current state of the PR takes those tests and:

(a) Refactors them some using a trait as was suggested in #3130104-11: Add unit test coverage for LanguageNegotiationBrowser → . That trait will then be used in that issue as well as any child issues of #3129860: Parts of the language negotiation subsystem are not unit/kernel tested →
(b) Adds an extra assertion (relevant code change)

This should be ready for review as soon as the tests turn green.

Ready for review

Changes look good but the issue summary mentions tests for

• ::processOutbound()
• ::getLanguageSwitchLinks()

Which I don't see.

Added missing tests (and some updates related to using a shared trait/base class coming from 📌 Add unit test coverage for LanguageNegotiationBrowser Needs work )
Back to review

See tests were added for

::processOutbound()
::getLanguageSwitchLinks()

So removing the IS update tag.

Changes look good but do think this postpones 📌 Add unit test coverage for LanguageNegotiationBrowser Needs work as we are now mixing tickets.

Needs a rebase.

Please review.

Going to mark it but going to ask @rpayanm why didn't you just update the existing MR? It was pointing to the correct branch?

Going to mark it but going to ask @rpayanm why didn't you just update the existing MR? It was pointing to the correct branch?

I tried to do it, but I found hard conflicts to solve, since the previous patch did not have a lot of changes I created a new branch. Sorry about that.

This looks fine and we can always add/refine to the improved tests later.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.