Add unit test coverage for LanguageNegotiationBrowser

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Scratched out the remaining tasks as they appear to be completed. The MR contains the test for getLangCode().

Coverage looks good

Thanks for the review @quietone; I believe I responded to all points adequately

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Few small things but overall looks close.

Refactored into a yet simpler form, I think this may be it.

Appears @jungle has one open thread if that can be answered.

Other then that looks good!

Replied to the thread from @jungle (thanks, good shout). Setting this back to NR

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Disagreeing with the "Needs Review Queue Bot"

Seeing some weirdness myself.

Opening MR 2900 I see there are 30 files changed.
Clicking file tab I see 2
If I go to https://git.drupalcode.org/project/drupal/-/merge_requests/2900.diff I see TONS of changes.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

stefanos.petrakis → closed merge request !2900

Again, (in a new MR due to some issues with Gitlab's UI and the git history in the old branch), this is open for review.
The remaining open point from @jungle has been addressed.

Seems to be good now but think this maybe should be postponed for 📌 Extend unit test coverage for LanguageNegotiationContentEntity Fixed since the fixes intersect. This will have to be reviewed again when 📌 Extend unit test coverage for LanguageNegotiationContentEntity Fixed lands

I was looking at this again and this appears to be a duplicate of 🐛 Fix LanguageNegotiationContentEntity::getLangcode() errors thrown Fixed , which was committed last month. Looking more closely at the test cases I think this is adding some, such as

    // Case 3: LanguageManager available, a request is given, but
    // HTTP_ACCEPT_LANGUAGE is not provided.

I think what needs to happen is to improve the testing in the existing \Drupal\Tests\language\Unit\Plugin\LanguageNegotiation\LanguageNegotiationContentEntityTest with any tests cases that are new here.