- Status changed to RTBC
over 1 year ago 6:03pm 11 February 2023 - πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
Scratched out the remaining tasks as they appear to be completed. The MR contains the test for getLangCode().
Coverage looks good
- Status changed to Needs work
over 1 year ago 8:00am 20 February 2023 - Status changed to Needs review
over 1 year ago 9:52pm 24 February 2023 - π¨πSwitzerland stefanos.petrakis Biel, Switzerland
Thanks for the review @quietone; I believe I responded to all points adequately
- Status changed to Needs work
over 1 year ago 10:27pm 24 February 2023 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 7:17am 25 February 2023 - Status changed to Needs work
over 1 year ago 3:42pm 25 February 2023 - πΊπΈUnited States smustgrave
Few small things but overall looks close.
- Status changed to Needs review
over 1 year ago 8:53pm 25 February 2023 - π¨πSwitzerland stefanos.petrakis Biel, Switzerland
Refactored into a yet simpler form, I think this may be it.
- Status changed to Needs work
over 1 year ago 11:46pm 26 February 2023 - πΊπΈUnited States smustgrave
Appears @jungle has one open thread if that can be answered.
Other then that looks good!
- Status changed to Needs review
over 1 year ago 3:44pm 1 March 2023 - π¨πSwitzerland stefanos.petrakis Biel, Switzerland
Replied to the thread from @jungle (thanks, good shout). Setting this back to NR
- Status changed to Needs work
over 1 year ago 4:27pm 1 March 2023 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 4:37pm 1 March 2023 - π¨πSwitzerland stefanos.petrakis Biel, Switzerland
Disagreeing with the "Needs Review Queue Bot"
- πΊπΈUnited States smustgrave
Seeing some weirdness myself.
Opening MR 2900 I see there are 30 files changed.
Clicking file tab I see 2
If I go to https://git.drupalcode.org/project/drupal/-/merge_requests/2900.diff I see TONS of changes. - Status changed to Needs work
over 1 year ago 5:31pm 1 March 2023 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- @stefanospetrakis opened merge request.
- Status changed to Needs review
over 1 year ago 11:55am 2 March 2023 - π¨πSwitzerland stefanos.petrakis Biel, Switzerland
Again, (in a new MR due to some issues with Gitlab's UI and the git history in the old branch), this is open for review.
The remaining open point from @jungle has been addressed. - Status changed to RTBC
over 1 year ago 3:20pm 3 March 2023 - πΊπΈUnited States smustgrave
Seems to be good now but think this maybe should be postponed for π Extend unit test coverage for LanguageNegotiationContentEntity Fixed since the fixes intersect. This will have to be reviewed again when π Extend unit test coverage for LanguageNegotiationContentEntity Fixed lands
- Status changed to Needs work
over 1 year ago 2:43am 20 March 2023 - π³πΏNew Zealand quietone New Zealand
I was looking at this again and this appears to be a duplicate of π Fix LanguageNegotiationContentEntity::getLangcode() errors thrown Fixed , which was committed last month. Looking more closely at the test cases I think this is adding some, such as
// Case 3: LanguageManager available, a request is given, but // HTTP_ACCEPT_LANGUAGE is not provided.
I think what needs to happen is to improve the testing in the existing \Drupal\Tests\language\Unit\Plugin\LanguageNegotiation\LanguageNegotiationContentEntityTest with any tests cases that are new here.