- π¨πSwitzerland stefanos.petrakis@gmail.com Biel, Switzerland
Now that π Fix LanguageNegotiationMethodInterface::getLangcode() result docblock Fixed is fixed and there is no documentation-inconsistency aspect, this here issue can move forward. Setting it back to NR since my latest changes set the return values to NULL (as was originally) instead of FALSE. That way the change-set focuses only on the reported errors (see description).
- Status changed to RTBC
about 2 years ago 11:58pm 30 January 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Thanks @stefanos.petrakis for creating the separate issue and following this one through
This looks good to me
- Status changed to Fixed
about 2 years ago 11:39am 31 January 2023 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 5738144ad9 to 10.1.x and 681c999fea to 10.0.x. Thanks!
Not backporting to 9.5.x because the test needs changing because it has property typehints and we still support PHP 7.3 there and this is a minor bug.
-
alexpott β
committed 5738144a on 10.1.x
Issue #3130751 by stefanos.petrakis, Medha Kumari, larowlan, alexpott,...
-
alexpott β
committed 5738144a on 10.1.x
-
alexpott β
committed 681c999f on 10.0.x
Issue #3130751 by stefanos.petrakis, Medha Kumari, larowlan, alexpott,...
-
alexpott β
committed 681c999f on 10.0.x
Automatically closed - issue fixed for 2 weeks with no activity.