The "moderation_state" base field overrides cause install from existing config to fail

Open on Drupal.org →

Created on 22 April 2020, over 4 years ago

Updated 6 August 2024, about 1 month ago

Problem/Motivation

This issue first got reported in #2321071-38: BaseFieldOverride fails to take into account ContentEntityInterface::bundleFieldDefinitions() when invoking onFieldDefinitionUpdate() → .

The moderation_state base field overrides cause the Drupal install from existing config to fail.
See the explanation here #2321071-42: BaseFieldOverride fails to take into account ContentEntityInterface::bundleFieldDefinitions() when invoking onFieldDefinitionUpdate() → and also the rest of the comments there.

To reproduce:
1. Install Drupal using the minimal profile
drush site-install minimal
2. Enable Content Moderation and Content Translation
drush en content_moderation content_translation -y
3. Create a CT
4. Create a workflow and enable it on the CT
5. Go to admin/config/regional/content-language and enable "Content", save
6. Export configuration. You should get a config_override file for the moderation_state base field.
drush cex -y
7. Install Drupal using the existing configuration
drush site-install --existing-config
TypeError: Argument 2 passed to Drupal\Core\Entity\ContentEntityStorageBase::onFieldDefinitionUpdate() must implement interface Drupal\Core\Field\FieldDefinitionInterface, null given, called in /home/herve/Documents/commission/drupal/drupal-core/core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php on line 205 in /home/herve/Documents/commission/drupal/drupal-core/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php on line 463 #0 /home/herve/Documents/commission/drupal/drupal-core/core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php(205): Drupal\Core\Entity\ContentEntityStorageBase->onFieldDefinitionUpdate(Object(Drupal\Core\Field\Entity\BaseFieldOverride), NULL)

Proposed resolution

1.
-> will not work, see #7

2.
-> will not work, see #12

3.
-> will not work, see #14

4.
-> will not work, see #17

5.
-> may not be ideal, see #19

6. Remove moderation_state from the "Content language" form using hook_form_language_content_settings_form_alter, which would prevent the BFO creation.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Content moderation →

Last updated 1 day ago

Maintained by
🇦🇺Australia @Sam152

Created by

🇧🇪Belgium herved

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Needs Review Queue Initiative

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇦Ukraine Taran2L Lviv
Updated patch with just a new config archive (the previous one was not sorted correctly). Please review
Comment over 1 year ago →
🇺🇦Ukraine Taran2L Lviv
Those config archive are hard :)
Comment over 1 year ago →
🇺🇦Ukraine Taran2L Lviv
Hm, I think test with fixtures should go to the module
Comment over 1 year ago →
System Message
The last submitted patch, 48: 3129874-48.patch, failed testing. View results →
Comment over 1 year ago →
🇮🇳India mohit_aghera Rajkot
Status changed to Needs work over 1 year ago11:55pm 22 April 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Per #39

Should we find a way to throw an exception when a base field override is created, to prevent these leaking into installations in other ways? If we're doing this, it'd be nice to confidently say: there is never a BFO for any CM field, on any installation.

Do we need an update hook to delete the existing ones?

We're missing test coverage that asserts the option is missing from the UI and no BFO entities are created when submitting the UI.

Don't think these have been answered yet.
Comment about 1 month ago →
🇷🇴Romania ioana apetri
I updated the patch for the Drupal 10.3.x compatibility. Thank you!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024