- 🇮🇳India Nupur Badola
Reviewed 3118012-3.patch.txt, the patch has following issues
a) 3118012-3.patch.txt:9: trailing whitespace. 3118012-3.patch.txt:14: trailing whitespace. warning: 2 lines add whitespace errors. b) File does not follow the instruction given in readme.md file template. Please refer: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template - First commit to issue fork.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
12 months ago 10:46am 20 February 2024 - Status changed to Needs work
12 months ago 5:25am 21 February 2024 - 🇮🇳India Nupur Badola
Reviewed 3118012-7.patch,
1. Configuration section is missing which is a mandatory field. - First commit to issue fork.
- Status changed to Needs review
12 months ago 1:25pm 21 February 2024 - Status changed to Needs work
11 months ago 12:21pm 26 February 2024 - 🇮🇳India Nupur Badola
Reviewed MR!2,
If there is no configuration, then write like this as per template ## Configuration The module has no menu or modifiable settings. There is no configuration. When enabled, the module will prevent the links from appearing. To get the links back, disable the module and clear caches. - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
11 months ago 4:44am 27 February 2024 - Status changed to Needs work
11 months ago 7:52am 27 February 2024 - 🇵ðŸ‡Philippines kenyoOwen
Hi nitin_lama
I reviewed your changes and it addressed comment #14 but that is just a copy-paste of configuration in README.md template → it should be a configuration of the module.
Thank you.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
11 months ago 9:54am 28 February 2024 - Status changed to RTBC
11 months ago 9:28am 29 February 2024 - 🇮🇳India Nupur Badola
Reviewed MR!2, the file is updated as per the readme.md file template.
Hence marking it to RTBC.