Support ServiceClosureArgument in \Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dumpValue

Comment about 1 year ago →
🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Added a draft change record, we should add an example in the change record of how this looks in a services file. I don't understand this enough to add a good example.
Status changed to Needs review about 1 year ago6:07am 28 June 2023
Comment about 1 year ago →
🇨🇭Switzerland znerol
Adapted the example from https://symfony.com/doc/current/service_container/service_closures.html for the CR.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
Patch Failed to Apply
Status changed to Needs work about 1 year ago6:58am 28 June 2023
Comment about 1 year ago →
🇨🇭Switzerland znerol
#31 fails to apply, needs a reroll.
Status changed to Needs review 12 months ago4:40am 30 June 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
Custom Commands Failed
Comment 12 months ago →
🇮🇳India sagarchauhan
Rerolled patch on #31
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,569 pass
Comment 12 months ago →
🇮🇳India sagarchauhan
Reuploading the patch after fixing issues.
Status changed to RTBC 12 months ago8:28pm 30 June 2023
Comment 12 months ago →
🇨🇭Switzerland znerol
No substantial changes since #34, hence RTBC.

I removed the service declaration from the change record, since that isn't working with the custom YamlFileLoader Drupal is currently using. But for service definitions built programmatically, this patch still brings some benefits.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,575 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,805 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,805 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,806 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,808 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,818 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,819 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,823 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,830 pass
Comment 11 months ago →
🇨🇭Switzerland znerol
(also added a change record)
Status changed to Fixed 11 months ago10:19am 21 July 2023
Comment 11 months ago →
🇬🇧United Kingdom longwave UK
Committed and pushed be795a8d99 to 11.x. Thanks!

Let's continue in 📌 Replace ContainerAwareEventDispatcher with Symfony EventDispatcher Fixed which should become almost trivial now.

longwave → committed 92e703a6 on 11.x

Issue #3108020 by bonrita, Cyberwolf, sagarchauhan, znerol, borisson_:...

Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Status changed to Fixed 9 months ago9:29am 5 October 2023
Comment 9 months ago →
🇦🇺Australia dpi Perth, Australia
Just created a new issue for following up on ServiceClosureArgument with private services: 🐛 ServiceClosureArgument with private service references original non-existent service Needs review

Support ServiceClosureArgument in \Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dumpValue

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities