- πΊπΈUnited States greggmarshall Aurora/Denver, Colorado
Setting this back to needs work since the patch no longer applies.
- @timplunkett opened merge request.
- Status changed to Needs review
almost 2 years ago 2:40am 27 January 2023 - πΊπΈUnited States tim.plunkett Philadelphia
This conflicted in a tricky way with #2935999: Remove Layout Builder's hard dependency on Field UI β , so I might need to make a further adjustment depending on how these tests shake out
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 3:22am 27 January 2023 - πΊπΈUnited States smustgrave
Can review this but unassigning from myself.
MR appears to have command failure.
- Status changed to Needs review
almost 2 years ago 4:18pm 27 January 2023 - Status changed to RTBC
almost 2 years ago 5:48pm 27 January 2023 - πΊπΈUnited States smustgrave
Testing MR 3303
Confirmed the issue still on D10 following steps in IS
Applied the MR and am no longer seeing the warning in the logsRan the tests locally without the fix to verify they fail.
LayoutBuilderTestException : Warning: Undefined array key "label" Drupal\layout_builder\Form\ConfigureSectionForm->buildForm()() (Line: 134)
Great work!
- Status changed to Needs work
almost 2 years ago 7:30am 4 February 2023 - π³πΏNew Zealand quietone
@smustgrave, I notice that you have worked on the patch and setting this to RTBC. That is not normally done.
In #24 the remaining tasks wer listed as reviewing that the the tests are sufficient and the fix is sufficient. Since then there has been rerolls, updates to the patch, and testing. However, there are no comments evaluating the fix or a code review. I have update the remaining tasks to clarify that. The proposed resolution needs to be updated as well, the patch is not using 'isset'. I changed that to a TBA.
- πΊπΈUnited States tim.plunkett Philadelphia
@smustgrave rerolled a patch after someone broke it, I don't think they did any further work on it
- π²π²Myanmar pyaephyohein
'Warning: Undefined array key "region" in Drupal\field_layout\FieldLayoutBuilder->buildForm() (line 109 of core/modules/field_layout/src/FieldLayoutBuilder.php). ' this error occur in my drupal 10 web site what can i do bro and sis. Layout function error
- πΊπΈUnited States tim.plunkett Philadelphia
@pyaephyohein that's π PHP notice "Undefined index: region" on layout overrides when using the Field Layout module Needs work , different module.