Contrib.social

Undefined index: label when editing Layout Builder section

Open on Drupal.org →
Created on 15 January 2020, over 4 years ago
Updated 19 January 2024, 5 months ago

Problem/Motivation

This issue introduced the ability to add administrative labels to Layout Builder sections:

https://www.drupal.org/project/drupal/issues/3073872 →

However, the code assumes the administrative label field has a value. When editing a section which was created before this code was introduced, this results in an AJAX error and the section edit form doesn't load. This error appears in log:

Notice: Undefined index: label in Drupal\layout_builder\Form\ConfigureSectionForm->buildForm() (line 114 of /app/web/core/modules/layout_builder/src/Form/ConfigureSectionForm.php).

Added error from other if you don't receive the first error:
Notice: Undefined index: label in Drupal\layout_builder\Form\MoveBlockForm->buildForm() (line 126 of /web/core/modules/layout_builder/src/Form/MoveBlockForm.php)

Steps to reproduce

  1. Do a Standard install
  2. Enable layout_builder
  3. Enable layout_builder_test (see this link → about test modules)
  4. Configure Basic Page to use Layout Builder for default display
  5. Go to manage layout (/admin/structure/types/manage/page/display/default/layout)
  6. Click "Add Section" and select "Layout Without Label" and insert at the top of the layout.
  7. Click "Configure Section 1"
  8. Navigate to the Recent Log Messages (/admin/reports/dblog) and find Notice: Undefined index: label in Drupal\layout_builder\Form\ConfigureSectionForm->buildForm() (line 118 of /var/www/html/core/modules/layout_builder/src/Form/ConfigureSectionForm.php)
  9. Then find the Body block in Section 2 of the layout and click the "Move Block" contextual link.
  10. Navigate to recent log messages and see
    Notice: Undefined index: label in Drupal\layout_builder\Form\MoveBlockForm->buildForm() (line 129 of /var/www/html/core/modules/layout_builder/src/Form/MoveBlockForm.php)</li>
  <li>

Proposed resolution

TBA

Remaining tasks

Evaluate the fix
Code review

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/A

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Layout builder  →

Last updated about 3 hours ago

Created by

🇺🇸United States maskedjellybean Portland, OR

Live updates comments and jobs are added and updated live.
  • Blocks-Layouts

    Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States greggmarshall Aurora/Denver, Colorado

    Setting this back to needs work since the patch no longer applies.

  • Comment over 1 year ago →
    🇺🇸United States tim.plunkett Philadelphia

    Fixing the patch

  • @timplunkett opened merge request.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States tim.plunkett Philadelphia

    This conflicted in a tricky way with #2935999: Remove Layout Builder's hard dependency on Field UI → , so I might need to make a further adjustment depending on how these tests shake out

  • Issue was unassigned.
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    Can review this but unassigning from myself.

    MR appears to have command failure.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States tim.plunkett Philadelphia
  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    Testing MR 3303

    Confirmed the issue still on D10 following steps in IS
    Applied the MR and am no longer seeing the warning in the logs

    Ran the tests locally without the fix to verify they fail.
    LayoutBuilderTest

    Exception : Warning: Undefined array key "label"
Drupal\layout_builder\Form\ConfigureSectionForm->buildForm()() (Line: 134)

    Great work!

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇳🇿New Zealand quietone New Zealand

    @smustgrave, I notice that you have worked on the patch and setting this to RTBC. That is not normally done.

    In #24 the remaining tasks wer listed as reviewing that the the tests are sufficient and the fix is sufficient. Since then there has been rerolls, updates to the patch, and testing. However, there are no comments evaluating the fix or a code review. I have update the remaining tasks to clarify that. The proposed resolution needs to be updated as well, the patch is not using 'isset'. I changed that to a TBA.

  • Comment over 1 year ago →
    🇺🇸United States tim.plunkett Philadelphia

    @smustgrave rerolled a patch after someone broke it, I don't think they did any further work on it

  • Comment 5 months ago →
    🇲🇲Myanmar pyaephyohein

    'Warning: Undefined array key "region" in Drupal\field_layout\FieldLayoutBuilder->buildForm() (line 109 of core/modules/field_layout/src/FieldLayoutBuilder.php). ' this error occur in my drupal 10 web site what can i do bro and sis. Layout function error

  • Comment 5 months ago →
    🇺🇸United States tim.plunkett Philadelphia
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024