- ๐ฎ๐ชIreland markconroy
Thanks @Akhil Babu for this testing.
This looks like it's soooo close to being ready. let's get this final piece implemented to give us parity with Standard profile and then get this merged. Well done everyone, we're nearly there.
- Status changed to Needs review
about 2 years ago 2:04pm 1 February 2023 - ๐ญ๐บHungary Zsuffa Dรกvid
The difference between the grid view of umami and the default profile is caused by the missing "Media library" view mode of the media types.
Extended patch #12 to include these configs. Attached screenshots of media library grid before/after. - Status changed to Needs work
about 2 years ago 4:29pm 1 February 2023 - ๐บ๐ธUnited States smustgrave
CI failure in #23
Added screenshots from #23 to IS.
- Status changed to Needs review
about 2 years ago 11:03am 2 February 2023 - ๐ญ๐บHungary Zsuffa Dรกvid
Can someone tell me what can cause this test failure? Should I add
langcode: true
to the hidden section of the yml files, like incore.entity_view_display.media.video.default.yml
?1) Drupal\Tests\demo_umami\Functional\DemoUmamiProfileTest::testConfig Exception: core.entity_view_display.media.audio.media_library: Drupal\Component\Diff\Engine\DiffOpAdd::__set_state(array( 'type' => 'add', 'orig' => false, 'closing' => array ( 0 => ' langcode: true', ), ))
- Status changed to Needs work
about 2 years ago 5:36pm 2 February 2023 - ๐บ๐ธUnited States smustgrave
Can give it a shot. Would see how existing config handles the langcode and update the yml file where needed.
Will keep this one on my radar so I can review again.
- Status changed to Needs review
about 2 years ago 3:56pm 3 February 2023 - ๐ญ๐บHungary Zsuffa Dรกvid
Ok, I think I find the cause. In the existing config the langcode line was after
field_media_document: true
line.
Tests passed in local dev env.install config:
hidden: created: true langcode: true field_media_document: true
existing config:
hidden: created: true field_media_document: true langcode: true
New patch attached.
- Status changed to RTBC
about 2 years ago 7:40pm 3 February 2023 -
lauriii โ
committed 4714abf9 on 10.1.x
Issue #3097503 by andrewmacpherson, Zsuffa Dรกvid, raman.b, Akhil Babu,...
-
lauriii โ
committed 4714abf9 on 10.1.x
- Status changed to Fixed
about 2 years ago 7:59am 14 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.