- Status changed to Needs review
over 1 year ago 9:10am 21 March 2023 - Status changed to Needs work
over 1 year ago 1:17pm 21 March 2023 - 🇺🇸United States smustgrave
@Nikhil_110 screenshot of the patch applying is not needed as the tests running show us that.
#19 the interdiff and patch are the same so not sure what was captured. Seems some size was lost from #2 if that could documented why please.
- First commit to issue fork.
- Status changed to Needs review
about 2 months ago 7:38am 14 July 2024 - 🇳🇿New Zealand quietone New Zealand
This is a bug because the documentation is incorrect. And thus, it is rather strict on making the minimal change to correct the documentation.
- Status changed to Needs work
about 2 months ago 1:28pm 17 July 2024 - 🇺🇸United States smustgrave
Thank for the grep @quietone
MR appears to need manual rebase.
- Status changed to Needs review
about 2 months ago 7:04am 18 July 2024 - Status changed to RTBC
about 2 months ago 1:56pm 18 July 2024 - 🇺🇸United States smustgrave
Using the grep provided by @quietone believe all instances have been updated.
- Status changed to Needs work
about 1 month ago 7:27am 25 July 2024 - Status changed to Needs review
about 1 month ago 8:28am 25 July 2024 - Status changed to Needs work
about 1 month ago 11:35pm 25 July 2024 - 🇨🇭Switzerland Berdir Switzerland
Reviewed. Tagging this with "Novice" seems.. brave, lots of special cases here to think about.
- 🇳🇿New Zealand quietone New Zealand
quietone → changed the visibility of the branch 3094865-fix-references-to to hidden.
- 🇳🇿New Zealand quietone New Zealand
quietone → changed the visibility of the branch 3094865-fix-references-to to active.
- Status changed to Needs review
about 1 month ago 1:14am 26 July 2024 - 🇳🇿New Zealand quietone New Zealand
@Berdir, thanks for the review. I responded to all the comments.
Good point about the novice tag, so I will remove it.
- Status changed to RTBC
about 1 month ago 9:27am 28 July 2024 - 🇨🇭Switzerland Berdir Switzerland
Thanks @quietone, the adjustments looks good to me. I changed "a Action entity" to "an Action entity", think it's still OK for me to RTBC this then.
- Status changed to Fixed
about 1 month ago 11:34am 29 July 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x, thanks!
Doesn't cherry-pick cleanly to 11.0.x, so just marking fixed.
Automatically closed - issue fixed for 2 weeks with no activity.