Contrib.social

Remove Firefox workaround for details focus effect

Open on Drupal.org →
Created on 4 October 2019, about 5 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

We have a workaround for the details focus effect to make it more consistent with Chrome. However, this makes the details element focus inconsistent with some other elements on the same browser. Since this is presumably expected behavior in Firefox (on OS X) and not a bug, we should consider whether we want to have this workaround or not.

The motivation is to make the focus effect behavior consistent across websites visited with the same browsers .

There aren't any macOS system settings that make a difference.

Steps to reproduce

  1. Install Drupal, log in with an admin user and visit /admin/config/system/site-information'.
  2. Click on the Site details summary, collapse and expand it. Using 'Stable' or 'Stark' themes, you will see the (browser-default) focus effect of the <summary> element in browsers, but not in Firefox on OS X operating system. With Claro theme, you will see the focus effect.
  3. Now focus the Site details summary with keyboard. You will see the focus effect of the <summary> element with every browser.

Proposed resolution

Remove Claro's details summary workaround and rely on Firefox's default behavior when it comes to details focus effects.

Remaining tasks

  • review
  • commit

User interface changes

Users using Firefox on OS X operating system won't see the focus effect of details summary if they are using their pointer device for collapsing or expanding the <details> element.

API changes

Nothing.

Data model changes

Nothing.

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Javascript  →

Last updated about 18 hours ago

Created by

🇫🇮Finland lauriii Finland

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Needs manual testing

    The change/bugfix cannot be fully demonstrated by automated testing, and thus requires manual testing in a variety of environments.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024