Support empty time range values

Works good and I think the 86401 is a reasonable value

The only thing we are missing now is an automated test to verify this functionality :)

I also needed this patch.

It seems to work fine!

hi, thank you generalredneck. It seems I also need patch in #10 after a d9.4.8 > d9.5.11 update, possible?

When trying to access a node the patch from #10 solves the error "InvalidArgumentException: Provided value is out of range. in Drupal\time_field\Time::assertInRange() (line 64 of modules/contrib/time_field/src/Time.php)". The node edit page was also broken (impossible to access/edit the node). Should I open a new ticket for this report ? (as it may need more attention and a higher priority level as the error fully broke the access to the /node/xx/edit page).

I'll be trying to make the tests

Just noticed that this patch actually completely bypasses the field validation. If you set the field as required you can simply save without entering any value at all...

Added kernel test

Automatically closed - issue fixed for 2 weeks with no activity.

After the update from 2.1.0 to 2.1.1 I am getting this error during a cron:

InvalidArgumentException: Provided value is out of range. in Drupal\time_field\Time::assertInRange() (line 64 of modules/contrib/time_field/src/Time.php).

A few lines of the stack trace:

#0 modules/contrib/time_field/src/Time.php(145): Drupal\time_field\Time::assertInRange('86401', 0, 86400)
#1 modules/contrib/time_field/src/Plugin/Field/FieldFormatter/TimeFormatter.php(36): Drupal\time_field\Time::createFromTimestamp('86401')
#2 modules/contrib/time_field/src/Plugin/Field/FieldFormatter/TimeFormatter.php(47): Drupal\time_field\Plugin\Field\FieldFormatter\TimeFormatter->viewValue(Object(Drupal\time_field\Plugin\Field\FieldType\TimeType))

Looks like the same error as in #15 ✨ Support empty time range values Fixed . I am running Drupal core 10.2.3.

@Jan-E What is the value you're trying to submit?

@BramDriessen I really would not know. It also happened when a cron was invoked from outside the site.

This was the first time it happened, on a time that almost nothing was done on the site:

I've been testing this for a bit but I can't seem to reproduce it :/ if you would happen to be able to debug a bit and see what the values are/where they come from that would help.

@BramDriesen thanks for getting back on this.

I just had this once again. Somehow the exact value 86401 gets entered in a time field. When cron runs it apparently tries to clear up the entity cache and falls into the error.

The previous occasion I remedied it by manually deleting the field instance and the revision instance from the database. I will try to change the value into 86400 now. And will try to find out how users manage to enter 86401.

I think there is someone else with a similar issue in 🐛 After 2.1.1 update all time fields are treated as required; empty values not accepted. Postponed: needs info