Table Render Array Example Is Incorrect

Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup

I will work on this in Drupal Con

crasx → closed merge request !4120

KarimB → closed merge request !5012

KarimB → closed merge request !5013

KarimB → closed merge request !5014

Actually the example is working fine. No need to explicitly declare the #rows property when adding sub-elements (or children) to $form['contacts'] (the main table element). When adding children like $form['contacts'][$i][...] these children will populate the #rows property automatically in preRenderTable(). I added some comments for better understanding.

I also added a new example with the #rows property explicitly declared and added information for #footer and #caption.

(I made a merge request to 11.x)

Hope this help ;)

Thank you for working on this @KarimB. Since it seems the original issue summary is different from what you found could you update the issue summary please

Removing the Novice tag as this issue has been to various contribution events, so keeping this in Novice won't be helpful.

Added the issue template for guidance, also title doesn't seem to accurately describe the issue. Sorry I should have flagged that earlier in #27, that's my fault.

Thanks, this reads well to me so lets see!

Thanks for contributing to better documentation!

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.

Thanks to @smustgrave for adding the standard template. That is a big help!

I applied the diff locally and read the changes. What I read is a great improvement! There are lines that are not wrapped correctly, so those will need to be changed. And I have a question which I left in the MR.

Also want to say that this is staying within scope by not changing the 9 usages of the old array syntax in the existing example. It does mean the example is a mixture of old and new array syntax which is unfortunate and another committer my disagree and want that changed here. But there are coding standard issues to fix the old array syntax in @code @endcode examples.

I am working on this issue now as part of a novice contribution workshop at Symetris → .

Fixed wrapping on docblocks.
Fixed array format.

Hope this helps.

Seems wrapping feedback has been addressed.

Issue credits

Checked out locally and verified all the text wrapped at 80 chars.

Committed to 11.x and backported to 10.2.x

Thanks folks 💪

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → closed merge request !5015