- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
If I'm understanding the deprecation was figured out in D9 so this should be updated to do the deprecation warning.
Will need a test to show the message.
- First commit to issue fork.
- 🇺🇸United States nicxvan
Addressing 13 we don't need tests showing deprecation messages per the deprecation policy.
- 🇨🇭Switzerland berdir Switzerland
This looks good to me, the only question is about BC, I think EntityFieldManagerInterface is a 1:1 interface and we can add methods there, but it could still break of someone for example decorates that service.
Implementing the interface finds finds only one contrib, and that's a false positive, that has its own Interface, it also doesn't extend core.
https://git.drupalcode.org/search?group_id=2&scope=blobs&search=%22imple...extends finds a few, two test stubs and one real subclass, those _should_ be fine:
https://git.drupalcode.org/search?group_id=2&scope=blobs&search=%22exten...Who knows what kind of shenanigans people did with custom code :shrug:
Was about to RTBC, but the change record should have a before/after example even if it's trivial. It possibly should also more clearly say that this method has been added to EntityFieldManagerInterface.
- 🇳🇿New Zealand quietone
This needs a rebase and I left some comments in the MR.
@nicxvan, why did you tag this as 11.2.0 release priority?
- 🇨🇭Switzerland berdir Switzerland
> @nicxvan, why did you tag this as 11.2.0 release priority?
Because this is a blocker to deprecate hook_hook_info() usage, as it relies on those extra include files being loaded.
- 🇺🇸United States nicxvan
Great thanks! I applied most suggestions, I'll rebase and address the rest of your comments later today or early tomorrow.
@berdir is right this is one of two blockers to deprecate hook hook info which is the real target.
- 🇺🇸United States nicxvan
Ok I address your comments and rebased, I fixed one more typo as well.
I'll keep an eye on tests and move status after.