- Status changed to Postponed
over 1 year ago 4:54am 23 July 2023 - 🇳🇿New Zealand quietone
This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.
This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.
- Status changed to Needs work
7 months ago 10:27pm 1 May 2024 - Status changed to Needs review
5 months ago 7:51am 19 June 2024 - Status changed to Needs work
5 months ago 2:38pm 19 June 2024 - Status changed to Needs review
5 months ago 12:23pm 24 June 2024 - Status changed to Needs work
5 months ago 12:36pm 24 June 2024 - 🇮🇳India ankitv18
@kalpanajaiswal I've left some comments and Tests are also failing please check.
- First commit to issue fork.
- Status changed to Needs review
3 months ago 2:17pm 18 August 2024 - 🇮🇳India akashpj
Hi, I've addressed the feedback which is mentioned in MR !10.
- Refactored the
$element['is_active']
assignment to use a ternary operator for simplicity. - Replaced the direct
\Drupal::routeMatch()
call withRouteMatchInterface
by injecting it into theBookManager
constructor. - Updated the service definition to include
@current_route_match
.
Please review the chnages and let me know if any further changes are required.
- Refactored the
- 🇺🇸United States smustgrave
MR is unmergable. Probably could add a simple assertion somewhere too.
- Assigned to mdranove
- Status changed to Fixed
22 days ago 3:34pm 30 October 2024 Automatically closed - issue fixed for 2 weeks with no activity.