🇮🇳India @akashpj

akashpj → made their first commit to this issue’s fork.

the_g_bomb → credited akashpj → .

Hi, I've addressed the feedback which is mentioned in MR !10.

1. Refactored the $element['is_active'] assignment to use a ternary operator for simplicity.
2. Replaced the direct \Drupal::routeMatch() call with RouteMatchInterface by injecting it into the BookManager constructor.
3. Updated the service definition to include @current_route_match.

Please review the chnages and let me know if any further changes are required.

akashpj → made their first commit to this issue’s fork.

I have tried to apply the MR 4 in Drpal 10.2.x but MR failed to apply and i got the below error

$ git apply -v 4.diff
4.diff:11: trailing whitespace.
  daterangepicker.min.js, daterangepicker.css" Library.
Checking patch README.md...
Checking patch css/daterangepicker.css...
Checking patch daterange_picker.info.yml...
error: while searching for:
description: 'Provides the ability to select from and to-date.'
package: daterange_picker
core_version_requirement: ^9 || ^10


error: patch failed: daterange_picker.info.yml:3
error: daterange_picker.info.yml: patch does not apply
Checking patch daterange_picker.libraries.yml...
Checking patch daterange_picker.module...
Checking patch src/Plugin/Field/FieldFormatter/DateRangePickerFormatter.php...
Checking patch src/Plugin/Field/FieldType/DateRangePickerType.php...
Checking patch src/Plugin/Field/FieldWidget/DateRangePicker.php...

Hi, I’ve reviwed MR 36 on Drupal 10.2.x.
The MR applied cleanly.

Few phpcs issues fixed but I still can see the below issues

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/config_pages

FILE: /Users/apj/projects/doc102/drupal/modules/contrib/config_pages/config_pages.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /Users/apj/projects/doc102/drupal/modules/contrib/config_pages/src/Plugin/Condition/ConfigPagesValueAccess.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 217 | WARNING | Unused variable $cp_type.
 217 | WARNING | Unused variable $data_type.
----------------------------------------------------------------------------------------------------------------------------------

Changing the status back to "Needs work".

Thanks

Tested #39 patch in drupal 9.5.x and 10.1.x
patch applied successfully and working as expected
Verified the changes suggested in #35 - Changes are addressed.