- Issue created by @mlncn
- @mlncn opened merge request.
- 🇺🇸United States mlncn Minneapolis, MN, USA
This merge request fixes the links. It is against 10.4.x because of course the problem is gone in 11.x— the modules are gone!
I really think that we should also change the text in the module title / description to make it clear that each "Deprecation" is really being moved into the core Help module and Drupal core systems, respectively. With any encouragement i'll take a try at wording.
Also would it be possible to have a different lifecycle than
deprecated
formoved
orincorporated
extensions? - 🇬🇧United Kingdom longwave UK
Test failure looks real, one of the tests looks for the SDC deprecation message.
- 🇺🇸United States mlncn Minneapolis, MN, USA
Thank you! Updated the test since the point is that link it is checking is wrong!
(Is there an easier way to see test failures than clicking six layers deep through the pipeline reports in code.drupal.org?)
- 🇺🇸United States smustgrave
(Is there an easier way to see test failures than clicking six layers deep through the pipeline reports in code.drupal.org?)
The MR on the ticket appears red if it has issue if that's what you mean. Also should receive an email if the pipeline fails.
Re-ran the nightwatch test and it was random failure.
Change makes sense also.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇿New Zealand quietone
This needs a rebase and an issue summary update to change the scope to just updating the link for SDC. The other were changed in 🐛 Fix any lifecycle_links as needed Active .
- First commit to issue fork.
- First commit to issue fork.
- 🇮🇳India akulsaxena
Reverted the change in the help_topics.info.yml file since it was out of scope based on summary and title of the issue as mentioned in #20.
Please have a look and let me know if any more changes are required. - 🇮🇳India sagarmohite0031
Hello
Tested and verified on Drupal 10.
MR applied successfully.
Adding before and after screenshot - 🇮🇳India akulsaxena
Sorry, missed the change from '-' to '_'
Made necessary changes
Please review -
longwave →
committed e02f07bc on 10.3.x
Issue #3480855 by mlncn, akulsaxena, smustgrave: Update lifecycle link...
-
longwave →
committed e02f07bc on 10.3.x
-
longwave →
committed fb7ce626 on 10.4.x
Issue #3480855 by mlncn, akulsaxena, smustgrave: Update lifecycle link...
-
longwave →
committed fb7ce626 on 10.4.x
-
longwave →
committed cb28d50b on 10.5.x
Issue #3480855 by mlncn, akulsaxena, smustgrave: Update lifecycle link...
-
longwave →
committed cb28d50b on 10.5.x
- 🇬🇧United Kingdom longwave UK
Committed and pushed cb28d50b8a8 to 10.5.x and fb7ce626967 to 10.4.x and e02f07bc153 to 10.3.x. Thanks!