- 🇳🇿New Zealand quietone
I tried again today to use cspell for this. I added "e-mail" to the flagWords and ran spellcheck on core and the instances were found. So, something has changed since longwave tried this in #17.
A core committer explained in #8 that work was not needed until a sniff was made in Coder. And that was repeated in #15 and #17. Patches and screenshots continued to be posted. That is not helping to resolve this and make noise in the issue. I am removing credit per How is credit granted for Drupal core issues → .
- Status changed to Needs review
over 1 year ago 8:53am 24 July 2023 - last update
over 1 year ago 29,878 pass - 🇳🇿New Zealand quietone
Let's get this back on track.
I have made a new patch, from scratch. I added 'e-mail' as a flag word and the spell checked all of core to find the instances. I fixed those and spell checked again. The dictionary does not need to be changed. I haven't included an interdiff because the previous patches include changes to migrate related files and that will just add noise to the interdiff.
The reroll in #36 does not have a diff and it didn't take into account the previous comments about the change of approach nor that the changes to migrate files (#8) should be removed. Therefor, I am removing credit.
- Status changed to RTBC
over 1 year ago 10:52am 24 July 2023 - 🇫🇮Finland lauriii Finland
Ran
yarn spellcheck:core
locally and it didn't return any errors:CSpell: Files checked: 14818, Issues found: 0 in 0 files
Reviewed the patch manually to confirm all of the changes there look good 👍
- 🇬🇧United Kingdom longwave UK
+++ b/core/.cspell.json @@ -49,7 +49,8 @@ "flagWords": [ "grey", "hte", - "please" + "please", + "e-mail" ],
Nitpick: should we keep this list in alphabetical order?
- Status changed to Needs review
over 1 year ago 11:44am 24 July 2023 - last update
over 1 year ago 29,865 pass, 2 fail - Status changed to RTBC
over 1 year ago 12:01pm 24 July 2023 The last submitted patch, 42: 3051548-42.patch, failed testing. View results →
- last update
over 1 year ago 29,877 pass - 🇫🇮Finland lauriii Finland
Random fail: 🐛 Random test fail in Drupal\Tests\Component\Utility\RandomTest::testRandomMachineNamesUniqueness Needs work .
-
longwave →
committed 758cc0ec on 11.x
Issue #3051548 by Rkumar, quietone, Balu Ertl, nitesh624, lauriii,...
-
longwave →
committed 758cc0ec on 11.x
- Status changed to Fixed
over 1 year ago 4:00pm 24 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 3:49pm 10 August 2023 - 🇬🇧United Kingdom jonathan1055
As this has been fixed without the use of a new sniff in Coder, it is confusing to have that issue linked in the IS, therefore I have removed it. It is still in the related issues, which is OK.