Toolbar breakpoints and media query used in toolbar CSS are incoherent

Created on 4 March 2019, almost 6 years ago
Updated 23 June 2023, over 1 year ago

Problem/Motivation

I think that the media query used in toolbar.icons.theme.css should be the same as the toolbar.standard breakpoint.

Proposed resolution

Standardize the standard media query.

Remaining tasks

Decide which one we prefer, and provide a patch (toolbar module and stable theme).

User interface changes

Not too much, but definitely something...

API changes

Nothing.

Data model changes

Nothing.

Notes

My preference is to provide the active toolbar breakpoint from ToolBar to the HTML document (e.g. by classes) and use that info for theming the different toolbar layouts instead of repeating the media query statically:

  • .toolbar if no layout is active (below the narrow breakpoint, in unoriented mode)
  • .toolbar--narrow
  • .toolbar--standard
  • .toolbar--wide
🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Toolbar 

Last updated about 1 month ago

  • Maintained by
  • 🇫🇷France @nod_
Created by

🇭🇺Hungary huzooka Hungary 🇭🇺🇪🇺

Live updates comments and jobs are added and updated live.
  • Needs screenshots

    The change alters the user interface, so before and after screenshots should be added to document the UI change. Make sure to capture the relevant region only. Use a tool such as Aviary on Windows or Skitch on Mac OS X.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024