Contextual links can be used to drag and drop Layout Blocks.

This is actually a really quick fix. The Sortable library has a filter param which can be used to exclude selectors from triggering the drag behaviour.

The issue here is around testing, I'm not sure with the current setup if we can add testing around this

Could SortableTestTrait be used and then check that the order is unchanged when trying to grab the contextual link? Probably can extend an existing test.

Unless I'm mistaken, SortableTestTrait doesn't actually do the drag & drop, it simulates it so that wouldn't work.

However when you mousedown on a sortable element you a class gets added if it's draggable. I may be able to test the class gets added when you mousedown over a draggable element, and does not get added when you mousedown over the .contextual element.

I'm not 100% sure either but if that doesn't work I can just put the manual testing results and maybe that's enough

Added some test coverage

So tried the test-only feature and locally but the test is passing without the fix.

Let’s just remove the tests and mark it unless you can think of any other example in core that could simulate this

I've reverted the test coverage, you're correct that is was passing regardless. I didn't realise that waitForElementVisible doesn't throw an exception and I haven't found a good way to do a mouse down + hold

Manually testing can confirm the issue is fixed. And don’t think it’s something we have to worry about being reverted accidentally.

Thanks for trying the tests!

nod_ → closed merge request !6689

Nice

Committed 41a731d and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.