The Needs Review Queue Bot โ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฎ๐ณIndia nikhil_110
Attached patch against Drupal 10.1.x
Patch #9 is not applied for Drupal 10.1.x so Inter-diff file is not added.
- last update
almost 2 years ago 29,371 pass - Status changed to Needs review
8 months ago 12:01pm 31 July 2024 - Status changed to Needs work
8 months ago 12:09pm 31 July 2024 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
8 months ago 2:28pm 31 July 2024 - Status changed to RTBC
8 months ago 2:53pm 5 August 2024 - Status changed to Needs work
8 months ago 8:59am 20 August 2024 - ๐ซ๐ทFrance nod_ Lille
This doesn't seem enough, we need a variable name. In PHP you need to do
function test(...$params) {}
for this to work, so doc needs to be
@param string โฆ$params
, we can't have only theโฆ
. - Status changed to Needs review
8 months ago 10:17pm 20 August 2024 - ๐ณ๐ฟNew Zealand quietone
@nod_, thanks. I converted that without much though, sorry.
- Status changed to Needs work
8 months ago 10:20pm 20 August 2024 - Status changed to Needs review
2 months ago 8:46am 21 January 2025 - ๐บ๐ธUnited States smustgrave
Believe feedback has been addressed on this one. Based on the D11 release know we search for drupal:12.0.0 so should be good there.
- ๐ณ๐ฟNew Zealand quietone
I checked in on this and noticed that the links in the @todo were incorrect. I updated them and rebased.
- ๐ณ๐ฑNetherlands daffie
@quietone: It is for me RTBC with or without the nitpicks.
- ๐บ๐ธUnited States smustgrave
believe feedback has been addressed on this one.
- Status changed to RTBC
1 day ago 8:55am 4 April 2025 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
Maybe there is a small misconception in the deprecation ignore file? See comment inline