- 🇨🇭Switzerland berdir Switzerland
@catch: That would be useful but would also make this a bit more complicated. We actually don't know the entity type in this method, we just get a list of entities and it's called twice from \Drupal\views\Plugin\views\query\Sql::loadEntities in separate blocks, so we'd need to add logging there in both cases if loading fails and then skip it without logging in this method. Worth it?
- Status changed to Needs work
over 2 years ago 9:27pm 17 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- @berdir opened merge request.
- Status changed to Needs review
over 1 year ago 3:26pm 25 February 2024 - Status changed to Needs work
over 1 year ago 3:44pm 25 February 2024 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 8:11am 24 April 2024 - 🇮🇳India arunkumark Coimbatore
Updated the MR with references to the fix done on 📌 Deprecate watchdog_exception Fixed
- Status changed to Needs work
about 1 year ago 1:22pm 24 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India arunkumark Coimbatore
Verified, able to merge to 11.x verified in local.
- Status changed to Needs review
about 1 year ago 4:22pm 24 April 2024 - Status changed to Needs work
about 1 year ago 4:47pm 24 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- @arunkumark opened merge request.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3029434-loading-entities-fix to hidden.
- Status changed to Needs review
about 1 year ago 6:05am 25 April 2024 - Status changed to Needs work
about 1 year ago 2:47pm 25 April 2024 - 🇺🇸United States smustgrave
Left comment on MR but also has test failures.