User account default setting for cancel confirm is not used

Here is a ptach compatible with 10.2.7

This came up as daily target for the #bugsmash initative.

Looking at the summary appears to be missing some sections, specifically what are the steps. Recommend using the standard issue template.

Also will need some kind of test coverage if a bug.

Also all fixes should be in MRs.

I think I remember that the current tests are falsely passing (without any patch). As I recall, it was a while ago, I think I found that there were tests scenarios that were never activated and as such the tests always just passed, but I could be wrong.

I think with this new setting I tried to update the tests, to check all the scenarios but found I couldn't get to the point where they could pass.

Hopefully #32 or #35 have improved that.

That latest patch doesn't include any test changes at all, I would ignore that and can only assume it is here to get the functionality added to a site without tests.

I will try to take another look.

As this issue was raised as a follow up to #2854884: Not able to disable account cancel confirm e-mail → , which looks like it was fixed in #2854252: User forms broken for admin without 'administer users' → . Hopefully the original tests were fixed there too.

This issue provides a form that allows the default setting to be changed and used if it is set.

We will need to check how the changes to the original issue has affected the tests and if they need to be updated to use the default settings.

Added a new test, but need to fixup old tests too.

I think there is some work required in core/modules/user/src/Form/UserMultipleCancelConfirm.php as well.

Left comments on the MR. Seems to contain a number of out of scope changes. If they're all needed to get the tests to just pass then something is probably missing.

But new config key will need a schema + upgrade path.

Issue summary still needs some attention.

mdranove → changed the visibility of the branch 11.x to hidden.

mdranove → closed merge request !11074

I added thread to the usercancelTest.php. There is a function that makes PHPSTAN fail as it doesnt exist.

Took another look on a new branch. Should be good now.

@mdranove You may have had a particular reason? but normally it's best to stick to one branch per issue. Anyway checking your latest changes.

Still appears to be missing default config, schema, and post update.

Also with the fix being in user module that’s probably where test coverage should be.

@mdranove Just ran the test-only test (you have to run it manually). It is passing but it should fail. What that normally means is the test coverage is passing before and after the code fixes in the MR are applied. That is not happening. Changing to 'needs work'.

@mdranove I see the test-only test is now failing and only one other test is failing. Worth re-running. For #63 hopefully the test code that seems to work can be moved/ refactored into the user module.

Re: #63 There are two tests in the user module.
Re: #66 The thread has been resolved. Test coverage seems also ready for review. Back to 'Needs review.'

Also summary is still incomplete.

Also think we need to think this one through a little now that I'm looking more closely

'When enabled, the user must confirm the account cancellation via email.'),

While this does set the checkbox to TRUE the person can still uncheck it.