🇬🇷Greece @s.messaris

This is indeed fixed on dev, but not usable, making this uninstallable if you want to go with Drupal 11. Can we get a release for this please?

Leaving as "needs work", since it will probably need at least a test.

Here is a patch with the proposed fix

s.messaris → created an issue.

Here are 2 patches, one for 2.0.x, and one for 2.0.7.

s.messaris → created an issue.

Here is a ptach compatible with 10.2.7

This is still an issue, steps from #9 worked for me.

Also related, 📌 Unconfigurable "Hire the maintainers" banner is against Policy on advertising in projects Needs review

s.messaris → created an issue.

I believe the governance team should also comment on the concerns regarding the newly added advertisement in commerce_shipping raised on 📌 Use the setting to allow disabling partner banners Fixed .

I wanted to open another ticket on this, but this one is a pretty close one, so I am adjusting it to cover it.

I see the concerns about project visibility as valid, I would love to get more visibility into ready-made solutions, especially around commerce, but I don't see ads in production code been a good way to do that.

If another non-Centarro contributor has their own sponsors and adds them to the same, or another page, would you still be ok with that? Don't you feel it's a slippery slope? I sure do.

And if you would be against that, that raises questions about the ownership of the module. How do we select who can add promotional ads in commerce? Is Drupal Commerce owned by Centarro, and thus should promote only your sponsors?

Lines like these becoming blurry is why we need community rules.

s.messaris → created an issue.

@smustgrave I found it used like that 10 times across 4 files, not including the new addition, that's why I did it this way.

core/modules/comment/tests/src/Kernel/CommentIntegrationTest.php
core/modules/dblog/tests/src/Functional/DbLogTest.php
core/modules/dblog/tests/src/Kernel/DbLogTest.php
core/modules/system/tests/src/Functional/Form/StorageTest.php

Also worked for my case, +1 for RTBC

I have had this change in one of my projects for a while, thought to try getting in contrib since it is useful in some cases.

Opened a MR, but leaving in "Needs work", since it at least surely needs some tests.

s.messaris → created an issue.

Test bot seems to like this after all, back to review :)

Wasn't the reroll, was the new test I added, I fixed it. Got an unrelated fail though, seems random, trying again.

Rerolled for 11.x and added the missing test scenarios

s.messaris → made their first commit to this issue’s fork.

Opened the issue fork and added a commit based on #27, implementing some of the optimization mglaman suggested in #39.

Leaving in "needs work" because I feel it can be optimized further.

Also we might want to add "view any unpubliched $bundle $type" permissions as well.

After using this for a good while without problems, I run into a problem with revisions. I am adding an updated patch with some code from \Drupal\entity_reference_revisions\Plugin\Field\FieldFormatter\EntityReferenceRevisionsFormatterBase::prepareView()