Add "is one of" (IN) operator for numeric fields

Created on 21 July 2023, over 1 year ago
Updated 7 October 2023, about 1 year ago
Feature request
Status

Needs work

Version

1.0

Component

Views integration

Created by

🇬🇷Greece s.messaris

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

  • Issue created by @s.messaris
  • Status changed to Needs work over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & sqlite-3.27
    last update over 1 year ago
    Composer require-dev failure
  • @smessaris opened merge request.
  • 🇬🇷Greece s.messaris

    I have had this change in one of my projects for a while, thought to try getting in contrib since it is useful in some cases.

    Opened a MR, but leaving in "Needs work", since it at least surely needs some tests.

  • Issue was unassigned.
  • 🇦🇹Austria drunken monkey Vienna, Austria

    Thanks for creating this MR!
    Does look like it might be useful for others, yes. You’re also right that it definitely needs some tests, but probably also some description for users on how to input the values. (Comma-separated doesn’t seem self-evident.) Furthermore, it seems to me like your code might lead to problems, depending on the backend, when a user includes whitespace with the commas (e.g., 1, 2 instead of 1,2).

    I’ll first wait for others to say that this would be helpful for them, and maybe to continue work here. But definitely something that could be added, if enough people find it useful. Thanks again!

Production build 0.71.5 2024