$settings['commerce_show_partner_banners'] should control visibility of "Hire the maintainers" banner

Created on 2 February 2024, 10 months ago
Updated 22 July 2024, 4 months ago

Reading the policy on https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... β†’

When it's something many site developers will want, it's admin-configurable, and it's disabled by default, see below.

The banner is there hardcoded and non configurable.

As a company or developer providing drupal development services, having this pop up on a client's site through an update, enabled by default, is causing very real financial harm.

The banner should be togglable and disabled by default, as per the policy on advertising in projects.

πŸ“Œ Task
Status

RTBC

Version

3.0

Component

User experience

Created by

πŸ‡¬πŸ‡·Greece s.messaris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @s.messaris
  • Status changed to Needs review 10 months ago
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update 10 months ago
    791 pass
  • πŸ‡¦πŸ‡ΊAustralia elc

    This is also not excluded by the $settings['commerce_show_partner_banners'] = FALSE; of the latest release. At present it is hard-coded into the twig template with no toggle. The template could be extended to include the variable.

    I have needed to patch this out as I am the contact person for my clients, not the community or maintainers. My clients are not the target audience for such advertising, I am, and I am well aware of my options.

    If a small business was building a site on their own, I could see the utility of having such a link. They will have already run into much of the information already as part of seeking out the project and installing it, but these links are an ongoing resource as they use the site.

    The ability to toggle it off even for those users is important though.

    Please find patch with respects the commerce_show_partner_banners value in the twig template.

  • Status changed to RTBC 4 months ago
  • πŸ‡ΊπŸ‡ΈUnited States mrweiner

    Seems to work as expected. This is actually my expected behavior for $settings['commerce_show_partner_banners'] = FALSE;.

    Changing the title to reflect the purpose of the patch. Policy concerns remain in the issue description.

Production build 0.71.5 2024