- Issue created by @s.messaris
- Status changed to Needs review
11 months ago 1:08am 9 February 2024 - last update
11 months ago 791 pass - π¦πΊAustralia elc
This is also not excluded by the
$settings['commerce_show_partner_banners'] = FALSE;
of the latest release. At present it is hard-coded into the twig template with no toggle. The template could be extended to include the variable.I have needed to patch this out as I am the contact person for my clients, not the community or maintainers. My clients are not the target audience for such advertising, I am, and I am well aware of my options.
If a small business was building a site on their own, I could see the utility of having such a link. They will have already run into much of the information already as part of seeking out the project and installing it, but these links are an ongoing resource as they use the site.
The ability to toggle it off even for those users is important though.
Please find patch with respects the
commerce_show_partner_banners
value in the twig template. - Status changed to RTBC
5 months ago 6:52pm 22 July 2024 - πΊπΈUnited States mrweiner
Seems to work as expected. This is actually my expected behavior for
$settings['commerce_show_partner_banners'] = FALSE;
.Changing the title to reflect the purpose of the patch. Policy concerns remain in the issue description.