- last update
almost 2 years ago 10,511 pass, 1 fail - First commit to issue fork.
- Merge request !8391issue/3019582: Implemented respective changes to address issue - Data saved in the 'function' column can be too long or have bad encoding → (Open) created by pooja_sharma
Moved the patch in MR against target branch 11.x
These mentioned changes are also addressed:
This needs tests. I suggest changing \Drupal\Tests\Core\Test\JUnitConverterTest::testConvertTestCaseToSimpletestRow to use a data provider and then adding new test cases.
Please review, moved NR
- Status changed to Needs review
9 months ago 6:25pm 12 June 2024 - Issue was unassigned.
- Status changed to Needs work
9 months ago 7:18pm 13 June 2024 pooja_sharma → changed the visibility of the branch 3019582-data-save-col-too-long to hidden.
pooja_sharma → changed the visibility of the branch 3019582-data-save-col-too-long to active.
Addressed the requested changes on the MR.
Please review , Moved NR
- Status changed to Needs review
9 months ago 11:08am 16 June 2024 - Status changed to Needs work
9 months ago 11:32am 20 June 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Resolved merge conflicts , rebased the MR.
Please review, moved NR.
- Status changed to Needs review
9 months ago 3:33pm 21 June 2024 - Status changed to Needs work
9 months ago 3:00pm 27 June 2024 facing issue while rebasing on local it seems source branch somehow corrupted
So I have create new branch + MR 8569, rebased the branch along with addressed mentioned changes
I have not idea how to move comments added on existiing MR
Please review , move NR
- Status changed to Needs review
9 months ago 9:13am 28 June 2024 - 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 3019582-data-save-col-too-long to hidden.
- Status changed to RTBC
8 months ago 1:47pm 8 July 2024 - 🇺🇸United States smustgrave
https://git.drupalcode.org/issue/drupal-3019582/-/jobs/2003591 shows the test coverage.
Also appears all feedback has been addressed so believe this one is good.
- Status changed to Needs work
8 months ago 12:27pm 17 July 2024 Replied on the comment, as there are not any changes done, so put back to prev RTBC status
- Status changed to RTBC
8 months ago 5:51am 18 July 2024 - 🇳🇿New Zealand quietone
This is a nice wee fix.
I did leave comments that need attention.
- Status changed to Needs work
8 months ago 3:39am 29 July 2024 - Status changed to Needs review
8 months ago 8:25am 30 July 2024 Removed custom func , & reused the core inbulit func , addressed the feedback.
PLease review , moving NR.
- Status changed to RTBC
8 months ago 2:06pm 30 July 2024 - Status changed to Needs work
7 months ago 4:01am 18 August 2024 - 🇬🇧United Kingdom catch
Still a couple of outstanding threads on the MR (one that was there when I reviewed, one new one I just added).
- Assigned to pooja_sharma