Allow managed_file form elements to specify FILE_EXISTS_REPLACE behavior

Open on Drupal.org →

Created on 8 November 2018, about 6 years ago

Updated 6 April 2023, over 1 year ago

The managed_file FormElement (Drupal\file\Element\ManagedFile) valueCallback implementation calls file_managed_file_save_upload($element, $form_state) which calls _file_save_upload_from_form($element, $form_state). The default value for $replace is FILE_EXISTS_RENAME. It would be nice if the element provided an attribute that allows us to specify what we want the behavior to be.

Suggestion: Add a new attribute to the element #file_exists_behavior, retrieve that value in valueCallback, modify file_managed_file_save_upload to accept the argument (with a default value of FILE_EXISTS_RENAME) and pass it along to _file_save_upload_from_form.

✨ Feature request

Status

Needs work

Version

10.1 ✨

Component

File system →

Last updated about 11 hours ago

Maintained by
🇦🇺Australia @kim.pepper

Created by

🇺🇸United States vegantriathlete Lakewood, CO

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment over 1 year ago →
🇮🇳India nikhil_110
Attached patch against Drupal 10.1.x
Status changed to Needs review over 1 year ago12:34pm 6 April 2023
Comment over 1 year ago →
🇮🇳India nikhil_110
Status changed to Needs work over 1 year ago2:00pm 6 April 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
This seems like it could use an issue summary update.

Also test coverage will be needed.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024