Investigate PHP 7.3 workarounds

Created on 24 September 2018, over 5 years ago
Updated 9 January 2024, 5 months ago

Problem/Motivation

#2989734: PHP 7.3 compatibility β†’ made Drupal 8 pass on PHP 7.3 but we introduced some workarounds to overcome differences in PHP 7.3.

The workarounds are:

  • Drupal\KernelTests\Core\Entity\EntityQueryTest does not use list()
  • PrivateTempStore had to use DependencySerializationTrait - whilst the fix is correct we should work out what has changed in PHP's serialize()
  • BrowserTestBase::getDrupalSettings() had to change to use $this->getSession()->getPage()->getContent() instead of $this->getSession()->getPage()->getHtml() in order for it to work

Proposed resolution

Fix the tests or work out why this is happening.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

πŸ“Œ Task
Status

Closed: outdated

Version

11.0 πŸ”₯

Component
BaseΒ  β†’

Last updated about 1 hour ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
  • PHP 7.3

    The issue particularly affects sites running on PHP version 7.3.0 or later.

  • Contributed project blocker

    It denotes an issue that prevents porting of a contributed project to the stable version of Drupal due to missing APIs, regressions, and so on.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024