Map menu ids like main-menu when migrating node types

This does look correct to me. I tested using /upgrade and confirmed that the available menus were not updated in the UI. But when using the patch they are.

I have updated the patch and made a fail patch.

And lets update this for Drupal6 sources as well.

The last submitted patch, 16: 2998875-16-fail.patch, failed testing. View results →

With the help of benjifisher and xurizaemon I was able to get my ddev setup working.

Setup a Drupal7 instances
Created a content type called Test Menu, checking "Main Menu" and "Navigation"

With my Drupal10.1 instance running
Ran the import for content types
Verified the content type was brought over
Verified the bug that the menu settings are missing
Rolled back change

Applied patch
Verified the menu settings are now there.
Main Menu -> Main Navigation
Navigation -> Tools

The last submitted patch, 16: 2998875-16.patch, failed testing. View results →

#16 worked great for me!

More specifically:

• It applied cleanly for me on core 10.1.
• I successfully regenerated my node type migration (I'm using migrate-upgrade).
• I ran the node type migration with --update, and the menu settings came in properly 🎉
• I enabled a custom menu for one of my content types and re-ran the node type migration -- that menu setting came in properly, too (goal: test with a menu that isn't specifically mapped).

Thank you for the fix!!

The test passes when I run it locally, so I am asking the testbot to try again.

Based on Comment #18, I am setting the status back to RTBC. If the test fails, then the testbot will set it back to NW again.

I think the old DrupalCI testbot is seriously broken. I am creating a MR using the patch from Comment #16 so that we can test on GitLab CI.

That's better!

Tests pass on GitLab CI, and the test-only job fails as expected: https://git.drupalcode.org/issue/drupal-2998875/-/jobs/688968.

Committed/pushed to 11.x and cherry-picked to 10.3.x and 10.2.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.