Enabling "Edit" to show all contextual links breaks tabbing in edit forms in the backend

+++ b/core/modules/contextual/js/contextual.toolbar.js
@@ -31,9 +31,10 @@
+        isViewing: !$('body .contextual-region').length
+          ? true
+          : localStorage.getItem('Drupal.contextualToolbar.isViewing') !==
+            'false',

I found this hard to read - I think we can do this

document.querySelector('body .contextual-region') === null || localStorage.getItem('Drupal.contextualToolbar.isViewing') !== 'false'

and ditch jQuery too

Didn't manually test, but will keep on my list to do so (keeping at NR)

Made the change in #29 and quick testing shows it still works.

Enabled contextual links on an Article page
Went to /admin/content, where there are no contextual links and could tab normally.

Manually tested this and it works as designed.

Before: tabbing doesn't work
After: tabbing works

Thanks for accommodation lots of rounds of feedback here @smustgrave

The last submitted patch, 30: 2991686-30.patch, failed testing. View results →

Random failure

Who knows how often this tripped someone up? t seems like the kind of problem someone might attribute to their own user error when it's actually a fixable bug. Good fix and solid test coverage in the patch.

I committed to 10.1.x, and I'm checking to see if commit checks pass for 10.0.x to cherry-pick to account for any possible lint/formatting requirements.

Cherry picked this to 10.0.x. This addresses a bug that could otherwise be quite frustrating, so backporting this to 9.5.x would be nice to do. This will need a 9.5.x specific patch as 9x requires .es6.js files. Setting issue status to "Patch (to be ported)" and the provider of the patch can switch back to RTBC or Needs Review (depending on their patch-porting confidence level)

I have attached patch for 9.5.x. please review

The last submitted patch, 38: 2991686-38.patch, failed testing. View results →

Random failure

The last submitted patch, 38: 2991686-38.patch, failed testing. View results →

Fixed test failures, please review.

So even if it's a random failure we wouldn't solve it here. It would need to be it's own ticket.

Also the patch in #43 doesn't include the original patch so hiding that.

The last submitted patch, 38: 2991686-38.patch, failed testing. View results →

9.5 is now security only, so marking this as fixed and moving version to 10.0

Automatically closed - issue fixed for 2 weeks with no activity.