[2.x] Allow authentication via mail and password over OAuth2 module

This would be a great feature for 2.x! Thanks a lot, I'll see if I can squeeze in some time the next couple of weeks! :)

Needs a reroll for 2.x, please. Then we can proceed.

@Cryt1c - no need to create a new MR. The only difference is $query->accessCheck(TRUE);.
You can collaborate in https://git.drupalcode.org/project/email_registration/-/merge_requests/3

A new MR would make sense if the approach is completely different, but not if it's the same.

Cryt1c → closed merge request !34

@fjgarlin thanks for the info. I had some issues with pushing before. Now it worked and I have added my commit to your MR.

Perfect! Thanks for helping with the issue.

I guess, this can go back to "Needs review"?

needs to add strict types

Fixed my feedback

created https://www.drupal.org/project/email_registration/releases/2.0.0-rc5 →

Thank you, @andypost! I didn't find the time to review this!

Automatically closed - issue fixed for 2 weeks with no activity.

It looks like this heavily overlaps with ✨ [2.x] Allow authentication via mail and password over RPC Needs review . The new test passes even when EmailRegistrationServiceProvider is commented out, because that issue does its own mail to name lookup in the controller.

I was looking into this because of 🐛 UserAuth BC layer is not working for modules that use it to provide email based logins Active , because of that other issue, this module is currently _not_ directly affected by the 10.3 changes. (Apart from the failing commerce tests, due to 📌 Remove country setting from the installer Fixed . It will need to eventually adapt to those UserAuth changes in both the UserAuth implementation and the copy pasted controller, but that's a D12 deprecation. And on the plus side, that willl allow to remove a ton of code as only the new lookupAccount() method will need to be implemented.

Let's inline it with 10.3 core